Commit 1719d02
committed
fix: externalize prettier/plugins/estree to prevent bundling stale code
The vite config listed `prettier/plugins/estree.js` as external, but the
source imports `prettier/plugins/estree` (no .js extension). This mismatch
caused vite to bundle prettier's estree printer into the plugin instead of
keeping it external. When the user installs a newer version of prettier
(e.g. 3.6.2), the plugin still uses the old bundled estree code whose
`canAttachComment` function expects 2 arguments, while prettier 3.6+'s
core calls it with 1 argument. This causes a crash:
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
when formatting any .gts file that contains both a comment and a <template> tag.
The fix removes the .js extension from the external config so it matches
the actual import paths. Also adds a regression test case.
Closes #4241 parent a4bff8f commit 1719d02
5 files changed
Lines changed: 30 additions & 2 deletions
File tree
- tests
- cases/gts
- unit-tests
- __snapshots__
- config/__snapshots__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
298 | 306 | | |
299 | 307 | | |
300 | 308 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
298 | 306 | | |
299 | 307 | | |
300 | 308 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
298 | 306 | | |
299 | 307 | | |
300 | 308 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
| 9 | + | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
0 commit comments