From fc8cd7101742f2f299de72252eac78f9a106a85c Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Tue, 6 Oct 2026 00:12:10 +0200 Subject: [PATCH] Process single-line docblocks in NoSuperfluousPhpdocTags The fixer skipped single-line "/** ... */" docblocks, so a standalone "/** @inheritDoc */" (or a single-line superfluous tag) was kept and later expanded to multi-line instead of removed. php-cs-fixer processes both forms; blink now does too, removing the tag and leaving "/** */" for NoEmptyPhpdoc. --- .../fixer/rules/no_superfluous_phpdoc_tags.go | 2 +- .../no_superfluous_phpdoc_tags_config_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/blink/internal/fixer/rules/no_superfluous_phpdoc_tags.go b/blink/internal/fixer/rules/no_superfluous_phpdoc_tags.go index fa99afb015..ddf69ef71a 100644 --- a/blink/internal/fixer/rules/no_superfluous_phpdoc_tags.go +++ b/blink/internal/fixer/rules/no_superfluous_phpdoc_tags.go @@ -91,7 +91,7 @@ func (f NoSuperfluousPhpdocTags) Fix(s *tokens.Stream) bool { continue } d, ok := parseDoc(t.Value) - if !ok || d.single { + if !ok { continue } docChanged := false diff --git a/blink/internal/fixer/rules/no_superfluous_phpdoc_tags_config_test.go b/blink/internal/fixer/rules/no_superfluous_phpdoc_tags_config_test.go index 3541651408..59bfc82531 100644 --- a/blink/internal/fixer/rules/no_superfluous_phpdoc_tags_config_test.go +++ b/blink/internal/fixer/rules/no_superfluous_phpdoc_tags_config_test.go @@ -26,6 +26,20 @@ func TestNoSuperfluousPhpdocTagsConfig(t *testing.T) { if want := "