fix(orchestrator): remove the fs-only pause version gate

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
GitOrigin-RevId: 3ecf45739f605b97a6b9a4f3cfd1477d76ac3a49

Author: 2 people

packages/orchestrator/pkg/server/fc_version_gate_test.go

@@ -12,12 +12,11 @@ import (
 	"github.com/e2b-dev/infra/packages/shared/pkg/fcversion"
 )
 
-// TestFirecrackerSupports pins the server-side version gate for the E2B
-// snapshot feature set: only e2b-format releases >= 0.2.0 qualify; legacy
-// _hash builds — including dev builds that mechanically carry the endpoints —
-// and unparsable versions fail CLOSED. The gate feeds two call sites with
-// different failure modes (in-place checkpoint falls back to resume-fresh;
-// a filesystem-only pause is refused), so it must never err toward true.
+// TestFirecrackerSupports pins what the wrapper adds over the fcversion
+// predicates (whose floors sandbox_features_test.go owns): it reads the
+// RUNNING version off the sandbox config, and an unparsable version fails
+// CLOSED — a version-gated feature must never engage on a build outside the
+// release contract.
 func TestFirecrackerSupports(t *testing.T) {
 	t.Parallel()
 
@@ -33,13 +32,10 @@ func TestFirecrackerSupports(t *testing.T) {
 	cases := []struct {
 		version string
 		inPlace bool
-		fsOnly  bool
 	}{
-		{"v1.14-0.2.0", true, true},
-		{"v1.14-1.0.0", true, true},
-		{"v1.14-0.1.1", false, true},      // fs-only ships from 0.1.0; in-place needs the 0.2.0 balloon API
-		{"v1.14.1_6ecb627", false, false}, // legacy build carrying the endpoints: still refused
-		{"garbage", false, false},         // unparsable: fail closed
+		{"v1.14-0.2.0", true},
+		{"v1.14.1_6ecb627", false}, // legacy build carrying the endpoints: still refused
+		{"garbage", false},         // unparsable: fail closed
 	}
 
 	for _, tc := range cases {
@@ -49,8 +45,6 @@ func TestFirecrackerSupports(t *testing.T) {
 			sbx := mkSbx(tc.version)
 			assert.Equal(t, tc.inPlace,
 				firecrackerSupports(t.Context(), sbx, "in-place checkpoint", (*fcversion.Info).HasInPlaceCheckpoint))
-			assert.Equal(t, tc.fsOnly,
-				firecrackerSupports(t.Context(), sbx, "filesystem-only snapshot", (*fcversion.Info).HasFilesystemSnapshots))
 		})
 	}
 }

packages/orchestrator/pkg/server/pause_gate_test.go

@@ -413,10 +413,10 @@ func (s *Server) Create(ctx context.Context, req *orchestrator.SandboxCreateRequ
 		ClientId:              s.info.ClientId,
 		SchedulingMetadata:    schedulingMetadata,
 		FilesystemBootApplied: filesystemBooted,
-		// The version the sandbox actually runs, frozen for its lifetime:
-		// version-gated callers (the API's fs-only pre-checks) must read
-		// this instead of re-resolving, which can disagree with the frozen
-		// value whenever the flag moves.
+		// The resolved Firecracker version the sandbox actually runs, frozen
+		// for its lifetime. The API stores it so a version-gated feature can
+		// key off the running binary exactly instead of re-resolving the
+		// flag, which drifts from this frozen value whenever the flag moves.
 		ResolvedFirecrackerVersion: resolvedFCVersion,
 	}, nil
 }
@@ -834,18 +834,6 @@ func (s *Server) Pause(ctx context.Context, in *orchestrator.SandboxPauseRequest
 		telemetry.WithEnvdVersion(sbx.Config.Envd.Version),
 	)
 
-	// Version-gate filesystem-only snapshots BEFORE MarkStopping, while the
-	// sandbox is still fully live: producing one is part of the e2b release
-	// contract from 0.1.0, and silently taking a memory snapshot instead
-	// would betray an explicit memory:false. The API pre-checks this before
-	// committing its pause chain, so reaching here means a stale client or a
-	// direct gRPC caller; FailedPrecondition names the real cause either way.
-	if in.GetFilesystemOnly() && !firecrackerSupports(ctx, sbx, "filesystem-only snapshot", (*fcversion.Info).HasFilesystemSnapshots) {
-		return nil, status.Errorf(codes.FailedPrecondition,
-			"filesystem-only snapshots require an e2b firecracker release (>= 0.1.0); sandbox '%s' runs %q",
-			in.GetSandboxId(), sbx.Config.FirecrackerConfig.FirecrackerVersion)
-	}
-
 	marked := s.sandboxFactory.Sandboxes.MarkStopping(ctx, sbx.Runtime.SandboxID, sbx.LifecycleID)
 	if !marked {
 		telemetry.ReportCriticalError(ctx, "failed to mark sandbox as stopping", nil, telemetry.WithSandboxID(in.GetSandboxId()))