test(coder): Update Coder to 8.3.14 (#1264)

Author: klausi

.github/workflows/testing.yml

@@ -91,7 +91,7 @@ jobs:
         run: |
           mkdir coder
           cd coder
-          composer require drupal/coder:8.3.12 --no-interaction --no-progress
+          composer require drupal/coder:8.3.14 --no-interaction --no-progress
 
       - name: Run PHPUnit
         run: |
@@ -106,5 +106,4 @@ jobs:
 
       - name: Run PHPCS
         run: |
-          ./coder/vendor/bin/phpcs --config-set installed_paths ../../drupal/coder/coder_sniffer
           cd modules/graphql && ../../coder/vendor/bin/phpcs -p

phpcs.xml.dist

@@ -9,14 +9,6 @@
   <rule ref="Drupal"></rule>
   <rule ref="DrupalPractice"></rule>
 
-  <!-- TODO: Bug in Coder with variadic parameters -->
-  <rule ref="Drupal.Commenting.FunctionComment.ParamTypeSpaces">
-    <exclude-pattern>src/GraphQL/ResolverBuilder.php</exclude-pattern>
-  </rule>
-  <rule ref="Drupal.Commenting.FunctionComment.SpacingAfterParamType">
-    <exclude-pattern>src/GraphQL/ResolverBuilder.php</exclude-pattern>
-  </rule>
-
   <!-- We want to document the return type on the base class even when there is
     no return statement on the default implementation. -->
   <rule ref="Drupal.Commenting.FunctionComment.InvalidNoReturn">

src/GraphQL/Buffers/EntityBuffer.php

@@ -82,7 +82,7 @@ public function resolveBufferArray(array $buffer) {
         }, []);
       }
 
-      return isset($entities[$item['id']]) ? $entities[$item['id']] : NULL;
+      return $entities[$item['id']] ?? NULL;
     }, $buffer);
   }
 

src/GraphQL/Buffers/EntityRevisionBuffer.php

@@ -81,7 +81,7 @@ public function resolveBufferArray(array $buffer) {
         }, []);
       }
 
-      return isset($entities[$item['vid']]) ? $entities[$item['vid']] : NULL;
+      return $entities[$item['vid']] ?? NULL;
     }, $buffer);
   }
 

src/GraphQL/Buffers/EntityUuidBuffer.php

@@ -92,7 +92,7 @@ public function resolveBufferArray(array $buffer) {
         }, []);
       }
 
-      return isset($entities[$item['uuid']]) ? $entities[$item['uuid']] : NULL;
+      return $entities[$item['uuid']] ?? NULL;
     }, $buffer);
   }
 

src/GraphQL/Resolver/Condition.php

@@ -37,7 +37,7 @@ public function __construct(array $branches) {
    */
   public function resolve($value, $args, ResolveContext $context, ResolveInfo $info, FieldContext $field) {
     $branches = $this->branches;
-    while (list($condition, $resolver) = array_pad(array_shift($branches), 2, NULL)) {
+    while ([$condition, $resolver] = array_pad(array_shift($branches), 2, NULL)) {
       if ($condition instanceof ResolverInterface) {
         if (($condition = $condition->resolve($value, $args, $context, $info, $field)) === NULL) {
           // Bail out early if a resolver returns NULL.

src/PersistedQuery/PersistedQueryPluginBase.php

@@ -44,7 +44,7 @@ public function label() {
    */
   public function getDescription() {
     $plugin_definition = $this->getPluginDefinition();
-    return isset($plugin_definition['description']) ? $plugin_definition['description'] : '';
+    return $plugin_definition['description'] ?? '';
   }
 
   /**

src/Plugin/GraphQL/DataProducer/DataProducerProxy.php

@@ -253,7 +253,7 @@ protected function resolveUncached(DataProducerPluginInterface $plugin, ResolveC
   protected function resolveCached(DataProducerPluginCachingInterface $plugin, ResolveContext $context, FieldContext $field) {
     $prefix = $this->edgeCachePrefix($plugin);
     if ($cache = $this->cacheRead($prefix)) {
-      list($value, $metadata) = $cache;
+      [$value, $metadata] = $cache;
       $field->addCacheableDependency($metadata);
       return $value;
     }

src/Plugin/GraphQL/DataProducer/Routing/RouteEntity.php

@@ -107,7 +107,7 @@ public function __construct(
    */
   public function resolve($url, ?string $language, FieldContext $context): ?Deferred {
     if ($url instanceof Url) {
-      list(, $type) = explode('.', $url->getRouteName());
+      [, $type] = explode('.', $url->getRouteName());
       $parameters = $url->getRouteParameters();
       $id = $parameters[$type];
       $resolver = $this->entityBuffer->add($type, $id);