From 9f442503c6c978cd13dac120cb66727207598470 Mon Sep 17 00:00:00 2001 From: Jakub Konecki Date: Fri, 23 Jan 2015 00:20:42 +0000 Subject: [PATCH 1/4] Removed an unnecessary check for null reference which is causing a warning during compilation: CS0472: The result of the expression is always 'false' since a value of type 'System.Guid' is never equal to 'null'. --- .../Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs | 3 --- .../Streams/PersistentStream/PersistentStreamProvider.cs | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs b/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs index dfb72daab86..c611d247222 100644 --- a/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs +++ b/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs @@ -63,9 +63,6 @@ public Task Start() public IAsyncStream GetStream(Guid id, string streamNamespace) { - if (id == null) - throw new ArgumentNullException("id"); - var streamId = StreamId.GetStreamId(id, Name, streamNamespace); return providerRuntime.GetStreamDirectory().GetOrAddStream( streamId, diff --git a/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs b/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs index 70e905bbcee..64861af28d2 100644 --- a/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs +++ b/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs @@ -119,8 +119,6 @@ public async Task Start() public IAsyncStream GetStream(Guid id, string streamNamespace) { - if (id == null) throw new ArgumentNullException("id"); - var streamId = StreamId.GetStreamId(id, Name, streamNamespace); return providerRuntime.GetStreamDirectory().GetOrAddStream( streamId, () => new StreamImpl(streamId, this, IsRewindable)); From 7a56131ca8b02a307d0f9906764e2ba08b61999b Mon Sep 17 00:00:00 2001 From: Jakub Konecki Date: Fri, 23 Jan 2015 01:41:20 +0000 Subject: [PATCH 2/4] Fixed casing of file names in solution to match the actual file/class names. --- src/Orleans/Orleans.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Orleans/Orleans.csproj b/src/Orleans/Orleans.csproj index 2182c98e5b0..d751ccb08b1 100644 --- a/src/Orleans/Orleans.csproj +++ b/src/Orleans/Orleans.csproj @@ -278,7 +278,7 @@ - + @@ -291,7 +291,7 @@ - + From 924950e5b65532b8cb5ef6f92837bc0f75c36521 Mon Sep 17 00:00:00 2001 From: Jakub Konecki Date: Fri, 23 Jan 2015 00:20:42 +0000 Subject: [PATCH 3/4] Removed an unnecessary check for null reference which is causing a warning during compilation: CS0472: The result of the expression is always 'false' since a value of type 'System.Guid' is never equal to 'null'. --- .../Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs | 3 --- .../Streams/PersistentStream/PersistentStreamProvider.cs | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs b/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs index dfb72daab86..c611d247222 100644 --- a/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs +++ b/src/Orleans/Streams/SimpleMessageStream/SimpleMessageStreamProvider.cs @@ -63,9 +63,6 @@ public Task Start() public IAsyncStream GetStream(Guid id, string streamNamespace) { - if (id == null) - throw new ArgumentNullException("id"); - var streamId = StreamId.GetStreamId(id, Name, streamNamespace); return providerRuntime.GetStreamDirectory().GetOrAddStream( streamId, diff --git a/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs b/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs index 70e905bbcee..64861af28d2 100644 --- a/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs +++ b/src/OrleansRuntime/Streams/PersistentStream/PersistentStreamProvider.cs @@ -119,8 +119,6 @@ public async Task Start() public IAsyncStream GetStream(Guid id, string streamNamespace) { - if (id == null) throw new ArgumentNullException("id"); - var streamId = StreamId.GetStreamId(id, Name, streamNamespace); return providerRuntime.GetStreamDirectory().GetOrAddStream( streamId, () => new StreamImpl(streamId, this, IsRewindable)); From 2f14b4fbf253673e7aa7986b9cc33f206851b29e Mon Sep 17 00:00:00 2001 From: Jakub Konecki Date: Fri, 23 Jan 2015 01:41:20 +0000 Subject: [PATCH 4/4] Fixed casing of file names in solution to match the actual file/class names. --- src/Orleans/Orleans.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Orleans/Orleans.csproj b/src/Orleans/Orleans.csproj index 2182c98e5b0..d751ccb08b1 100644 --- a/src/Orleans/Orleans.csproj +++ b/src/Orleans/Orleans.csproj @@ -278,7 +278,7 @@ - + @@ -291,7 +291,7 @@ - +