From 092e82f3cc3da005216cf2aa13958028fbdd8063 Mon Sep 17 00:00:00 2001 From: Reuben Bond Date: Sat, 24 Jan 2015 09:53:35 +1100 Subject: [PATCH] ParseTimeSpan should parse into double in order to reduce the scope for numeric overflows. --- src/Orleans/Configuration/ConfigUtilities.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Orleans/Configuration/ConfigUtilities.cs b/src/Orleans/Configuration/ConfigUtilities.cs index eefd1f0f8e2..b6a5a7436d3 100644 --- a/src/Orleans/Configuration/ConfigUtilities.cs +++ b/src/Orleans/Configuration/ConfigUtilities.cs @@ -311,8 +311,8 @@ internal static TimeSpan ParseTimeSpan(string input, string errorMessage) unitSize = 1000; // Default is seconds numberInput = trimmedInput; } - int rawTimeSpan; - if (!Int32.TryParse(numberInput, out rawTimeSpan)) + double rawTimeSpan; + if (!double.TryParse(numberInput, out rawTimeSpan)) { throw new FormatException(errorMessage + ". Tried to parse " + input); }