Fixes bug in har responses encoding#1693
Open
waldekmastykarz wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect encoding when exporting HTTP bodies (notably in HAR generation and DevTools inspection) by centralizing body-to-string decoding and honoring Content-Type charset when provided.
Changes:
- Introduces a shared
HttpUtils.GetBodyStringhelper to decode request/response bodies usingContent-Typecharset or a UTF-8 fallback. - Updates
DevToolsPluginto use the shared decoding helper instead of its local implementation. - Updates
HarGeneratorPluginto decode bodies via the helper and to report body/content sizes based on raw byte length.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DevProxy.Plugins/Utils/HttpUtils.cs | Adds a shared body decoding helper to standardize charset handling across plugins. |
| DevProxy.Plugins/Inspection/DevToolsPlugin.cs | Replaces local body decoding with the shared helper for request/response body capture. |
| DevProxy.Plugins/Generation/HarGeneratorPlugin.cs | Uses shared decoding for HAR text fields and switches HAR size fields to byte-based lengths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.