Skip to content
This repository was archived by the owner on Aug 3, 2021. It is now read-only.
This repository was archived by the owner on Aug 3, 2021. It is now read-only.

Response Signated Signed-ness can flip when xml is read #112

Description

@Fusty

The value of samlResponse.isSigned() before this line is true

https://github.com/dotCMS/plugin-com.dotcms.dotsaml/blob/4.0-4.3.x/src/com/dotcms/plugin/saml/v3/handler/HttpPostAssertionResolverHandlerImpl.java#L94

After this line it is false.

This may be because I am logging at the DEBUG level.

I just ran into this while setting up a Google G-Suite Apps SAML IdP.

The fix is to verify the response signature before assertion xml is converted to an object. I'm not certain why this occurs, but it is consistent in my current environment and this tiny tweak fixes it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions