Skip to content

Commit 48e239b

Browse files
authored
Quiet vendored-only PR reviews (#25572)
## Summary Update the PR review prompt so vendored/generated-only changes get a single upstream-only response instead of inline style and content comments. Generated by Codex
2 parents 4d30fab + 29e85e5 commit 48e239b

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

.github/workflows/pr-review.yml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,25 @@ jobs:
3434
## Priority Issues
3535
3636
### 1. Vendored/Generated Content (CRITICAL - Auto-reject)
37-
Flag if changes touch:
37+
Check for vendored or generated files before reviewing any changed content.
38+
Treat these paths as vendored/generated:
3839
- Any file in `_vendor/` directory (vendored from upstream repos)
3940
- Any YAML file in `data/*/*.yaml` subdirectories (CLI reference data generated from upstream)
4041
- Examples: `data/engine-cli/*.yaml`, `data/buildx/*.yaml`, `data/scout-cli/*.yaml`
4142
- Exception: root-level data/ files are manually maintained (allow edits)
4243
- `content/reference/api/ai-governance/api.yaml` (verbatim copy of the upstream OpenAPI spec, vendored from the private docker/governor-services repo via `hack/sync-governance-api.sh`)
4344
45+
If all changed files are vendored/generated:
46+
- Leave at most one PR-level review comment.
47+
- Do not leave inline comments.
48+
- Do not review style, wording, markdown, command accuracy, links, or content quality inside those files.
49+
- Say only that the PR edits vendored/generated content, identify the affected path pattern, and direct the author to make the change upstream and sync it back.
50+
51+
If a PR changes both vendored/generated files and hand-authored files:
52+
- Leave one comment for the vendored/generated file issue.
53+
- Review only the hand-authored files for the remaining priority issues below.
54+
- Do not leave style, wording, markdown, command accuracy, link, or content-quality comments on vendored/generated files.
55+
4456
### 2. Missing Redirects When Removing/Moving Pages (HIGH)
4557
When a PR removes or moves a page:
4658
- Check if the PR adds an `aliases:` entry in the front matter of the target/replacement page

0 commit comments

Comments
 (0)