Create type alias for shifter gear numbers

Author: dmadison

src/SimRacing.cpp

@@ -605,7 +605,7 @@ LogitechDrivingForceGT_Pedals::LogitechDrivingForceGT_Pedals(PinNum gasPin, PinN
 //                       Shifter                          #
 //#########################################################
 
-Shifter::Shifter(int8_t min, int8_t max)
+Shifter::Shifter(Gear min, Gear max)
 	: MinGear(min), MaxGear(max)
 {}
 
@@ -716,7 +716,7 @@ bool AnalogShifter::update() {
 	// neutral and then immediately return
 	case(DeviceConnection::Unplug):
 	{
-		const int8_t previousGear = this->getGear();
+		const Gear previousGear = this->getGear();
 
 		analogAxis[Axis::X].setPosition(calibration.neutralX);
 		analogAxis[Axis::Y].setPosition(calibration.neutralY);
@@ -736,13 +736,13 @@ bool AnalogShifter::update() {
 		break;
 	}
 
-	const int8_t previousGear = this->getGear();
+	const Gear previousGear = this->getGear();
 	const bool prevOdd = ((previousGear != -1) && (previousGear & 1));  // were we previously in an odd gear
 	const bool prevEven = (!prevOdd && previousGear != 0);  // were we previously in an even gear
 
 	const int x = analogAxis[Axis::X].getPosition();
 	const int y = analogAxis[Axis::Y].getPosition();
-	int8_t newGear = 0;
+	Gear newGear = 0;
 
 	// If we're below the 'release' thresholds, we must still be in the previous gear
 	if ((prevOdd && y > calibration.oddRelease) || (prevEven && y < calibration.evenRelease)) {

src/SimRacing.h

@@ -470,13 +470,18 @@ namespace SimRacing {
 	*/
 	class Shifter : public Peripheral {
 	public:
+		/**
+		* Type alias for gear numbers
+		*/
+		using Gear = int8_t;
+
 		/**
 		* Class constructor
 		* 
 		* @param min the lowest gear possible
 		* @param max the highest gear possible
 		*/
-		Shifter(int8_t min, int8_t max);
+		Shifter(Gear min, Gear max);
 
 		/**
 		* Returns the currently selected gear.
@@ -486,7 +491,7 @@ namespace SimRacing {
 		*
 		* @return current gear index
 		*/
-		int8_t getGear() const { return currentGear; }
+		Gear getGear() const { return currentGear; }
 
 		/**
 		* Returns a character that represents the given gear.
@@ -537,21 +542,21 @@ namespace SimRacing {
 		*
 		* @return the lowest gear index
 		*/
-		int8_t getGearMin() { return MinGear; }
+		Gear getGearMin() { return MinGear; }
 
 		/**
 		* Retrieves the maximum possible gear index.
 		*
 		* @return the highest gear index
 		*/
-		int8_t getGearMax() { return MaxGear; }
+		Gear getGearMax() { return MaxGear; }
 
 	protected:
-		const int8_t MinGear;  ///< the lowest selectable gear
-		const int8_t MaxGear;  ///< the highest selectable gear
+		const Gear MinGear;  ///< the lowest selectable gear
+		const Gear MaxGear;  ///< the highest selectable gear
 
-		int8_t currentGear;    ///< index of the current gear
-		bool changed;          ///< whether the gear has changed since the previous update
+		Gear currentGear;    ///< index of the current gear
+		bool changed;        ///< whether the gear has changed since the previous update
 	};