Merge pull request #2543 from alexissellier/option-ignoring-helm-dependencies

feat: add a parameter to disable helm dependency update

Author: lizardruss

devspace-schema.json

@@ -744,6 +744,10 @@
           },
           "type": "array",
           "description": "TemplateArgs are additional arguments to pass to `helm template`"
+        },
+        "disableDependencyUpdate" : {
+          "type": "boolean",
+          "description" : "DisableDependencyUpdate disables helm dependencies update"
         }
       },
       "type": "object",

docs/pages/configuration/_partials/v2beta1/deployments/helm/disableDependencyUpdate.mdx

@@ -0,0 +1,12 @@
+
+<details className="config-field" data-expandable="false" open>
+<summary>
+
+#### `disableDependencyUpdate` <span className="config-field-required" data-required="false">required</span> <span className="config-field-type">boolean</span> <span className="config-field-default">false</span> <span className="config-field-enum"></span> {#deployments-helm-disableDependencyUpdate}
+
+DisableDependencyUpdate disables helm dependencies update
+
+</summary>
+
+
+</details>

docs/pages/configuration/_partials/v2beta1/deployments/helm_reference.mdx

@@ -6,6 +6,7 @@ import PartialValuesFiles from "./helm/valuesFiles.mdx"
 import PartialDisplayOutput from "./helm/displayOutput.mdx"
 import PartialUpgradeArgs from "./helm/upgradeArgs.mdx"
 import PartialTemplateArgs from "./helm/templateArgs.mdx"
+import PartialDisableDependencyUpdate from "./helm/disableDependencyUpdate.mdx"
 
 <PartialReleaseName />
 
@@ -39,3 +40,5 @@ Chart holds the chart configuration and where DevSpace can find the chart
 
 
 <PartialTemplateArgs />
+
+<PartialDisableDependencyUpdate />

docs/schemas/config-openapi.json

@@ -752,6 +752,10 @@
                 },
                 "type": "array",
                 "description": "TemplateArgs are additional arguments to pass to `helm template`"
+              },
+              "disableDependencyUpdate" : {
+                "type": "boolean",
+                "description" : "DisableDependencyUpdate disables helm dependencies update"
               }
             },
             "type": "object",

pkg/devspace/config/versions/latest/schema.go

@@ -840,6 +840,9 @@ type HelmConfig struct {
 	UpgradeArgs []string `yaml:"upgradeArgs,omitempty" json:"upgradeArgs,omitempty"`
 	// TemplateArgs are additional arguments to pass to `helm template`
 	TemplateArgs []string `yaml:"templateArgs,omitempty" json:"templateArgs,omitempty"`
+
+	// DisableDependencyUpdate disables helm dependencies update, default to false
+	DisableDependencyUpdate *bool `yaml:"disableDependencyUpdate" json:"disableDependencyUpdate"`
 }
 
 // ChartConfig defines the helm chart options

pkg/devspace/deploy/deployer/helm/deploy_test.go

@@ -71,7 +71,7 @@ func TestDeploy(t *testing.T) {
 				Deployments: []remotecache.DeploymentCache{
 					{
 						Name:                 "deploy2",
-						DeploymentConfigHash: "038007a9e5018dcf8ffbabad39c1fdc08251e583d7b19e74b765b815d5302444",
+						DeploymentConfigHash: "a5047fb615f1b300af8aebdcb2d806c51ff5c00d68653727c5386c40760cbc42",
 						Helm: &remotecache.HelmCache{
 							Release:          "deploy2",
 							ReleaseNamespace: "testNamespace",

pkg/devspace/helm/v3/client.go

@@ -108,11 +108,12 @@ func (c *client) InstallChart(ctx devspacecontext.Context, releaseName string, r
 	}
 
 	// Update dependencies if needed
-	stat, err := os.Stat(chartPath)
-	if err == nil && stat.IsDir() {
-		args = append(args, "--dependency-update")
+	if helmConfig.DisableDependencyUpdate == nil || (helmConfig.DisableDependencyUpdate != nil && !*helmConfig.DisableDependencyUpdate) {
+		stat, err := os.Stat(chartPath)
+		if err == nil && stat.IsDir() {
+			args = append(args, "--dependency-update")
+		}
 	}
-
 	// Upgrade options
 	args = append(args, helmConfig.UpgradeArgs...)
 	output, err := c.genericHelm.Exec(ctx, args)
@@ -190,11 +191,12 @@ func (c *client) Template(ctx devspacecontext.Context, releaseName, releaseNames
 	}
 
 	// Update dependencies if needed
-	stat, err := os.Stat(chartPath)
-	if err == nil && stat.IsDir() {
-		args = append(args, "--dependency-update")
+	if helmConfig.DisableDependencyUpdate == nil || (helmConfig.DisableDependencyUpdate != nil && !*helmConfig.DisableDependencyUpdate) {
+		stat, err := os.Stat(chartPath)
+		if err == nil && stat.IsDir() {
+			args = append(args, "--dependency-update")
+		}
 	}
-
 	args = append(args, helmConfig.TemplateArgs...)
 	result, err := c.genericHelm.Exec(ctx, args)
 	if err != nil {