fix: show error if yaml reading failed

Author: FabianKramm

.golangci.yml

@@ -1,5 +1,8 @@
 run:
   timeout: 10m
+  skip-dirs:
+  - hack/
+  - docs/
 
 linters:
   disable-all:  true

helper/util/conn.go

@@ -2,6 +2,7 @@ package util
 
 import (
 	"context"
+	"google.golang.org/grpc/credentials/insecure"
 	"io"
 	"net"
 
@@ -13,7 +14,7 @@ func NewClientConnection(reader io.Reader, writer io.Writer) (*grpc.ClientConn,
 	pipe := NewStdStreamJoint(reader, writer, false)
 
 	// Set up a connection to the server.
-	return grpc.Dial("", grpc.WithInsecure(), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) {
+	return grpc.Dial("", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) {
 		return pipe, nil
 	}))
 }

pkg/devspace/deploy/deployer/helm/deploy.go

@@ -1,6 +1,7 @@
 package helm
 
 import (
+	"fmt"
 	"github.com/loft-sh/devspace/pkg/devspace/config/versions"
 	"io"
 	"os"
@@ -218,11 +219,10 @@ func (d *DeployConfig) getDeploymentValues(ctx devspacecontext.Context) (bool, m
 	if d.DeploymentConfig.Helm.ValuesFiles != nil {
 		for _, overridePath := range d.DeploymentConfig.Helm.ValuesFiles {
 			overwriteValuesPath := ctx.ResolvePath(overridePath)
-
 			overwriteValuesFromPath := map[string]interface{}{}
 			err = yamlutil.ReadYamlFromFile(overwriteValuesPath, overwriteValuesFromPath)
 			if err != nil {
-				ctx.Log().Warnf("Error reading from chart dev overwrite values %s: %v", overwriteValuesPath, err)
+				return false, nil, fmt.Errorf("error reading from chart dev overwrite values %s: %v", overwriteValuesPath, err)
 			}
 
 			// Replace image names

pkg/devspace/deploy/deployer/helm/deploy_test.go

@@ -60,10 +60,9 @@ func TestDeploy(t *testing.T) {
 		// 	},
 		// },
 		{
-			name:        "Deploy one deployment",
-			deployment:  "deploy2",
-			chart:       ".",
-			valuesFiles: []string{"."},
+			name:       "Deploy one deployment",
+			deployment: "deploy2",
+			chart:      ".",
 			values: map[string]interface{}{
 				"val": "fromVal",
 			},
@@ -72,7 +71,7 @@ func TestDeploy(t *testing.T) {
 				Deployments: []remotecache.DeploymentCache{
 					{
 						Name:                 "deploy2",
-						DeploymentConfigHash: "d4caa406182729245229e8cc01179a72f3cfe3f2fcb4685255b821d711235be4",
+						DeploymentConfigHash: "038007a9e5018dcf8ffbabad39c1fdc08251e583d7b19e74b765b815d5302444",
 						Helm: &remotecache.HelmCache{
 							Release:          "deploy2",
 							ReleaseNamespace: "testNamespace",