Skip to content

Commit a32aff7

Browse files
authored
Merge pull request #2663 from Juneezee/chore/yaml
chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`
2 parents 2f751b0 + 5947e58 commit a32aff7

21 files changed

Lines changed: 20 additions & 1004 deletions

File tree

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ require (
1717
github.com/evanphx/json-patch/v5 v5.1.0
1818
github.com/fujiwara/shapeio v1.0.0
1919
github.com/gertd/go-pluralize v0.2.0
20-
github.com/ghodss/yaml v1.0.0
2120
github.com/gliderlabs/ssh v0.3.5
2221
github.com/go-resty/resty/v2 v2.7.0
2322
github.com/google/go-containerregistry v0.13.0

go.sum

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ github.com/fujiwara/shapeio v1.0.0/go.mod h1:LmEmu6L/8jetyj1oewewFb7bZCNRwE7wLCU
188188
github.com/gertd/go-pluralize v0.2.0 h1:VzWNnxkUo3wkW2Nmp+3ieHSTQQ0LBHeSVxlKsQPQ+UY=
189189
github.com/gertd/go-pluralize v0.2.0/go.mod h1:4ouO1Ndf/r7sZMorwp4Sbfw80lUni+sd+o3qJR8L9To=
190190
github.com/getkin/kin-openapi v0.76.0/go.mod h1:660oXbgy5JFMKreazJaQTw7o+X00qeSyhcnluiMv+Xg=
191-
github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk=
192191
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
193192
github.com/gliderlabs/ssh v0.2.2/go.mod h1:U7qILu1NlMHj9FlMhZLlkCdDnU1DBEAqr0aevW3Awn0=
194193
github.com/gliderlabs/ssh v0.3.5 h1:OcaySEmAQJgyYcArR+gGGTHCyE7nvhEMTlYY+Dp8CpY=

pkg/devspace/build/builder/kaniko/build_pod.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,20 @@
11
package kaniko
22

33
import (
4+
"fmt"
45
"path/filepath"
56

67
"github.com/loft-sh/devspace/pkg/devspace/build/builder/kaniko/util"
78
devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
89

910
"github.com/docker/distribution/reference"
10-
jsonyaml "github.com/ghodss/yaml"
1111
"gopkg.in/yaml.v3"
12+
jsonyaml "sigs.k8s.io/yaml"
1213

1314
"github.com/docker/docker/api/types"
1415
"github.com/pkg/errors"
1516
k8sv1 "k8s.io/api/core/v1"
1617

17-
"fmt"
18-
1918
"github.com/loft-sh/devspace/pkg/devspace/pullsecrets"
2019
"k8s.io/apimachinery/pkg/api/resource"
2120
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/devspace/config/loader/testing/fake.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import (
66
"github.com/loft-sh/devspace/pkg/devspace/config"
77
"github.com/loft-sh/devspace/pkg/devspace/kubectl"
88

9-
"github.com/ghodss/yaml"
109
"github.com/loft-sh/devspace/pkg/devspace/config/constants"
1110
"github.com/loft-sh/devspace/pkg/devspace/config/loader"
1211
"github.com/loft-sh/devspace/pkg/devspace/config/localcache"
1312
"github.com/loft-sh/devspace/pkg/devspace/config/versions/latest"
1413
"github.com/loft-sh/devspace/pkg/util/log"
1514
"github.com/pkg/errors"
15+
"sigs.k8s.io/yaml"
1616
)
1717

1818
// FakeConfigLoader is the fake config loader

pkg/devspace/config/versions/v1beta10/upgrade_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
package v1beta10
22

33
import (
4-
"github.com/ghodss/yaml"
4+
"reflect"
5+
"testing"
6+
57
next "github.com/loft-sh/devspace/pkg/devspace/config/versions/v1beta11"
68
"github.com/loft-sh/devspace/pkg/util/log"
79
"github.com/loft-sh/devspace/pkg/util/ptr"
8-
"reflect"
9-
"testing"
10+
"sigs.k8s.io/yaml"
1011
)
1112

1213
type testCase struct {

pkg/devspace/config/versions/v1beta7/upgrade_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import (
44
"reflect"
55
"testing"
66

7-
"github.com/ghodss/yaml"
87
next "github.com/loft-sh/devspace/pkg/devspace/config/versions/v1beta8"
98
"github.com/loft-sh/devspace/pkg/util/log"
9+
"sigs.k8s.io/yaml"
1010
)
1111

1212
type testCase struct {

pkg/devspace/config/versions/v1beta8/upgrade_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import (
44
"reflect"
55
"testing"
66

7-
"github.com/ghodss/yaml"
87
next "github.com/loft-sh/devspace/pkg/devspace/config/versions/v1beta9"
98
"github.com/loft-sh/devspace/pkg/util/log"
9+
"sigs.k8s.io/yaml"
1010
)
1111

1212
type testCase struct {

pkg/devspace/config/versions/validate.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import (
66
"strings"
77
"unicode"
88

9-
jsonyaml "github.com/ghodss/yaml"
109
"github.com/pkg/errors"
1110
"gopkg.in/yaml.v3"
1211
k8sv1 "k8s.io/api/core/v1"
12+
jsonyaml "sigs.k8s.io/yaml"
1313

1414
"github.com/loft-sh/devspace/pkg/devspace/config/versions/latest"
1515
"github.com/loft-sh/devspace/pkg/util/dockerfile"

pkg/devspace/deploy/deployer/kubectl/builder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"regexp"
99
"strings"
1010

11-
jsonyaml "github.com/ghodss/yaml"
1211
"github.com/loft-sh/devspace/pkg/devspace/config/versions/latest"
1312
"github.com/loft-sh/devspace/pkg/devspace/pipeline/env"
1413
"github.com/loft-sh/devspace/pkg/util/constraint"
@@ -19,6 +18,7 @@ import (
1918
"k8s.io/client-go/tools/clientcmd"
2019
clientcmdapi "k8s.io/client-go/tools/clientcmd/api"
2120
"mvdan.cc/sh/v3/expand"
21+
jsonyaml "sigs.k8s.io/yaml"
2222
)
2323

2424
// Builder is the manifest builder interface

pkg/devspace/deploy/deployer/kubectl/kubectl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"os"
88
"strings"
99

10-
jsonyaml "github.com/ghodss/yaml"
1110
"github.com/loft-sh/devspace/pkg/devspace/config/constants"
1211
"github.com/loft-sh/devspace/pkg/devspace/config/loader/patch"
1312
"github.com/loft-sh/devspace/pkg/devspace/config/loader/variable/legacy"
@@ -26,6 +25,7 @@ import (
2625
"github.com/sirupsen/logrus"
2726
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2827
"mvdan.cc/sh/v3/expand"
28+
jsonyaml "sigs.k8s.io/yaml"
2929
)
3030

3131
var Cachemanifest = "./.devspace/manifest-cache.yaml"

0 commit comments

Comments
 (0)