Skip to content

Commit a2a0c62

Browse files
committed
refactor: purge deployments in reverse order
1 parent 5f68279 commit a2a0c62

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

e2e/tests/hooks/hooks.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ var _ = DevSpaceDescribe("hooks", func() {
5555
Pipeline: "build",
5656
SkipPush: false,
5757
}
58-
err = buildCmd.RunDefault(f)
58+
err = buildCmd.Run(nil, nil, f, "build", "buildCommand")
5959
framework.ExpectError(err)
6060

6161
// check if files are there
@@ -81,7 +81,7 @@ var _ = DevSpaceDescribe("hooks", func() {
8181
Pipeline: "dev",
8282
SkipPush: true,
8383
}
84-
err = devCmd.RunDefault(f)
84+
err = devCmd.Run(nil, nil, f, "dev", "devCommand")
8585
framework.ExpectError(err)
8686

8787
// check if files are correctly created

pkg/devspace/deploy/deploy.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,10 @@ func (c *controller) Purge(ctx *devspacecontext.Context, deployments []string) e
287287

288288
// Reverse them
289289
deploymentCaches := ctx.Config.RemoteCache().ListDeployments()
290-
for _, deploymentCache := range deploymentCaches {
290+
for i := len(deploymentCaches) - 1; i >= 0; i-- {
291+
// Deployment cache
292+
deploymentCache := deploymentCaches[i]
293+
291294
// Check if we should skip deleting deployment
292295
if deployments != nil {
293296
found := false

0 commit comments

Comments
 (0)