fix local-registry remote buildkit error: [415: Unsupported Media Type], compatibility legacy kube api server which not support server-side apply

Signed-off-by: wurenny <wurenny@gmail.com>

Author: wurenny

pkg/devspace/build/localregistry/deployment.go

@@ -5,6 +5,7 @@ import (
 	"time"
 
 	devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
+	"github.com/loft-sh/devspace/pkg/devspace/kubectl"
 	"github.com/loft-sh/devspace/pkg/util/ptr"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -63,14 +64,21 @@ func (r *LocalRegistry) ensureDeployment(ctx devspacecontext.Context) (*appsv1.D
 	if err != nil {
 		return nil, err
 	}
-	return ctx.KubeClient().KubeClient().AppsV1().Deployments(r.Namespace).Apply(
+	apply, err := ctx.KubeClient().KubeClient().AppsV1().Deployments(r.Namespace).Apply(
 		ctx.Context(),
 		applyConfiguration,
 		metav1.ApplyOptions{
 			FieldManager: ApplyFieldManager,
 			Force:        true,
 		},
 	)
+	if err != nil && kubectl.IsIncompatibleServerError(err) {
+		ctx.Log().Debugf("Server-side apply not available on the server for localRegistry deployment: (%v)", err)
+		// Unsupport server-side apply, we use existing or created deployment
+		return existing, nil
+	}
+
+	return apply, err
 }
 
 func (r *LocalRegistry) getDeployment() *appsv1.Deployment {

pkg/devspace/build/localregistry/service.go

@@ -5,6 +5,7 @@ import (
 	"time"
 
 	devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
+	"github.com/loft-sh/devspace/pkg/devspace/kubectl"
 	corev1 "k8s.io/api/core/v1"
 	kerrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -50,15 +51,21 @@ func (r *LocalRegistry) ensureService(ctx devspacecontext.Context) (*corev1.Serv
 	if err != nil {
 		return nil, err
 	}
-
-	return ctx.KubeClient().KubeClient().CoreV1().Services(r.Namespace).Apply(
+	apply, err := ctx.KubeClient().KubeClient().CoreV1().Services(r.Namespace).Apply(
 		ctx.Context(),
 		applyConfiguration,
 		metav1.ApplyOptions{
 			FieldManager: ApplyFieldManager,
 			Force:        true,
 		},
 	)
+	if err != nil && kubectl.IsIncompatibleServerError(err) {
+		ctx.Log().Debugf("Server-side apply not available on the server for localRegistry service: (%v)", err)
+		// Unsupport server-side apply, we use existing or created service
+		return existing, nil
+	}
+
+	return apply, err
 }
 
 func (r *LocalRegistry) getService() *corev1.Service {

pkg/devspace/build/localregistry/statefulset.go

@@ -5,6 +5,7 @@ import (
 	"time"
 
 	devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
+	"github.com/loft-sh/devspace/pkg/devspace/kubectl"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	kerrors "k8s.io/apimachinery/pkg/api/errors"
@@ -59,14 +60,21 @@ func (r *LocalRegistry) ensureStatefulset(ctx devspacecontext.Context) (*appsv1.
 	if err != nil {
 		return nil, err
 	}
-	return ctx.KubeClient().KubeClient().AppsV1().StatefulSets(r.Namespace).Apply(
+	apply, err := ctx.KubeClient().KubeClient().AppsV1().StatefulSets(r.Namespace).Apply(
 		ctx.Context(),
 		applyConfiguration,
 		metav1.ApplyOptions{
 			FieldManager: ApplyFieldManager,
 			Force:        true,
 		},
 	)
+	if err != nil && kubectl.IsIncompatibleServerError(err) {
+		ctx.Log().Debugf("Server-side apply not available on the server for localRegistry statefulset: (%v)", err)
+		// Unsupport server-side apply, we use existing or created statefulset
+		return existing, nil
+	}
+
+	return apply, err
 }
 
 func (r *LocalRegistry) getStatefulSet() *appsv1.StatefulSet {

pkg/devspace/kubectl/client.go

@@ -3,11 +3,6 @@ package kubectl
 import (
 	"context"
 	"fmt"
-	"io"
-	"net/http"
-	"os"
-	"time"
-
 	"github.com/loft-sh/devspace/pkg/devspace/config/localcache"
 	"github.com/loft-sh/devspace/pkg/devspace/kill"
 	"github.com/loft-sh/devspace/pkg/devspace/kubectl/util"
@@ -17,7 +12,11 @@ import (
 	"github.com/loft-sh/devspace/pkg/util/log"
 	"github.com/loft-sh/devspace/pkg/util/survey"
 	"github.com/loft-sh/devspace/pkg/util/terminal"
+	"io"
 	"k8s.io/apimachinery/pkg/util/wait"
+	"net/http"
+	"os"
+	"time"
 
 	"github.com/mgutz/ansi"
 	"github.com/pkg/errors"

pkg/devspace/kubectl/util.go

@@ -276,3 +276,13 @@ func GetKindContext(context string) string {
 
 	return strings.TrimPrefix(context, "kind-")
 }
+
+func IsIncompatibleServerError(err error) bool {
+	// 415: Unsupported media type means we're talking to a server which doesn't support server-side apply.
+	// Also included the apiserver enabled feature: ServerSideApply=false option
+	if _, ok := err.(*kerrors.StatusError); !ok {
+		// Non-StatusError means the error isn't because the server is incompatible.
+		return false
+	}
+	return err.(*kerrors.StatusError).Status().Code == http.StatusUnsupportedMediaType
+}