Skip to content

Commit 5b67f9e

Browse files
committed
fix: --dependency flag is respected by git pulling
Signed-off-by: André S. Hansen <andre.ok@online.no>
1 parent 41c8128 commit 5b67f9e

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

cmd/run_pipeline.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ func initialize(ctx context.Context, f factory.Factory, options *CommandOptions,
340340
}
341341

342342
// resolve dependencies
343-
dependencies, err := f.NewDependencyManager(devCtx, options.ConfigOptions).ResolveAll(devCtx, dependency.ResolveOptions{SkipDependencies: options.DependencyOptions.Exclude})
343+
dependencies, err := f.NewDependencyManager(devCtx, options.ConfigOptions).ResolveAll(devCtx, dependency.ResolveOptions{SkipDependencies: options.DependencyOptions.Exclude, Dependencies: options.DependencyOptions.Only})
344344
if err != nil {
345345
return nil, errors.Wrap(err, "deploy dependencies")
346346
}

pkg/devspace/dependency/manager.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ package dependency
22

33
import (
44
"bytes"
5+
"strings"
6+
57
"github.com/loft-sh/devspace/pkg/devspace/build"
68
"github.com/loft-sh/devspace/pkg/devspace/config/loader"
79
devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
@@ -11,7 +13,6 @@ import (
1113
"github.com/loft-sh/devspace/pkg/util/log"
1214
"github.com/pkg/errors"
1315
"github.com/sirupsen/logrus"
14-
"strings"
1516
)
1617

1718
// Manager can update, build, deploy and purge dependencies.
@@ -39,7 +40,7 @@ func NewManagerWithParser(ctx devspacecontext.Context, configOptions *loader.Con
3940

4041
type ResolveOptions struct {
4142
SkipDependencies []string
42-
Dependencies []string
43+
Dependencies []string // Same as DependencyOptions.Only, either should be renamed
4344
}
4445

4546
func (m *manager) ResolveAll(ctx devspacecontext.Context, options ResolveOptions) ([]types.Dependency, error) {

pkg/devspace/dependency/resolver.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"github.com/loft-sh/devspace/pkg/devspace/dependency/types"
1919
"github.com/loft-sh/devspace/pkg/devspace/dependency/util"
2020
"github.com/loft-sh/devspace/pkg/devspace/kubectl"
21+
"github.com/loft-sh/devspace/pkg/util/stringutil"
2122
"github.com/pkg/errors"
2223
)
2324

@@ -120,6 +121,10 @@ func (r *resolver) resolveRecursive(ctx devspacecontext.Context, basePath, paren
120121
continue
121122
}
122123

124+
if len(options.Dependencies) > 0 && !stringutil.Contains(options.Dependencies, dependencyConfig.Name) {
125+
continue
126+
}
127+
123128
if dependencyConfig.Disabled {
124129
ctx.Log().Debugf("Skip dependency %s, because it is disabled", dependencyConfig.Name)
125130
continue

0 commit comments

Comments
 (0)