small fixes around commands messages and comparison operator in js files

tukobadnyanoba · tukobadnyanoba · commit 336b4d261760 · 2022-04-12T20:29:38.000+05:30
diff --git a/cmd/add/add.go b/cmd/add/add.go
@@ -11,7 +11,7 @@ import (
 func NewAddCmd(f factory.Factory, globalFlags *flags.GlobalFlags, plugins []plugin.Metadata) *cobra.Command {
 	addCmd := &cobra.Command{
 		Use:   "add",
-		Short: "Convenience command: adds something to devspace.yaml",
+		Short: "Adds something to devspace.yaml",
 		Long: `
 #######################################################
 #################### devspace add #####################
diff --git a/cmd/add/plugin.go b/cmd/add/plugin.go
@@ -14,7 +14,7 @@ func newPluginCmd(f factory.Factory) *cobra.Command {
 	cmd := &pluginCmd{}
 	pluginCmd := &cobra.Command{
 		Use:   "plugin",
-		Short: "Add a plugin to devspace",
+		Short: "Adds a plugin to devspace",
 		Long: `
 #######################################################
 ############### devspace add plugin ###################
diff --git a/cmd/completion.go b/cmd/completion.go
@@ -43,7 +43,7 @@ func NewCompletionCmd() *cobra.Command {
 			return cobra.OnlyValidArgs(cmd, args)
 		},
 		ValidArgs: []string{"bash", "zsh"},
-		Short:     "Output shell completion for the given shell (bash or zsh)",
+		Short:     "Outputs shell completion for the given shell (bash or zsh)",
 		Long:      longDescription,
 		RunE:      completion,
 	}
diff --git a/cmd/deploy.go b/cmd/deploy.go
@@ -17,7 +17,7 @@ func NewDeployCmd(f factory.Factory, globalFlags *flags.GlobalFlags, rawConfig *
 
 	deployCmd := &cobra.Command{
 		Use:   "deploy",
-		Short: "Deploy the project",
+		Short: "Deploys the project",
 		Long: `
 #######################################################
 ################## devspace deploy ####################
diff --git a/cmd/list/deployments.go b/cmd/list/deployments.go
@@ -32,7 +32,7 @@ func newDeploymentsCmd(f factory.Factory, globalFlags *flags.GlobalFlags) *cobra
 #######################################################
 ############# devspace list deployments ###############
 #######################################################
-Shows the status of all deployments
+Lists the status of all deployments
 #######################################################
 	`,
 		Args: cobra.NoArgs,
diff --git a/cmd/logs.go b/cmd/logs.go
@@ -50,7 +50,7 @@ func NewLogsCmd(f factory.Factory, globalFlags *flags.GlobalFlags) *cobra.Comman
 #######################################################
 #################### devspace logs ####################
 #######################################################
-Logs prints the last log of a pod container and attachs 
+Prints the last log of a pod container and attachs 
 to it
 
 Example:
diff --git a/cmd/print.go b/cmd/print.go
@@ -45,7 +45,7 @@ func NewPrintCmd(f factory.Factory, globalFlags *flags.GlobalFlags) *cobra.Comma
 
 	printCmd := &cobra.Command{
 		Use:   "print",
-		Short: "Print displays the configuration",
+		Short: "Prints displays the configuration",
 		Long: `
 #######################################################
 ################## devspace print #####################
diff --git a/cmd/purge.go b/cmd/purge.go
@@ -17,7 +17,7 @@ func NewPurgeCmd(f factory.Factory, globalFlags *flags.GlobalFlags, rawConfig *R
 	}
 	purgeCmd := &cobra.Command{
 		Use:   "purge",
-		Short: "Delete deployed resources",
+		Short: "Deletes deployed resources",
 		Long: `
 #######################################################
 ################### devspace purge ####################
diff --git a/cmd/remove/remove.go b/cmd/remove/remove.go
@@ -11,7 +11,7 @@ import (
 func NewRemoveCmd(f factory.Factory, globalFlags *flags.GlobalFlags, plugins []plugin.Metadata) *cobra.Command {
 	removeCmd := &cobra.Command{
 		Use:   "remove",
-		Short: "Changes devspace configuration",
+		Short: "Removes devspace configuration",
 		Long: `
 #######################################################
 ################## devspace remove ####################
diff --git a/cmd/render.go b/cmd/render.go
@@ -21,7 +21,7 @@ func NewRenderCmd(f factory.Factory, globalFlags *flags.GlobalFlags, rawConfig *
 
 	renderCmd := &cobra.Command{
 		Use:   "render",
-		Short: "Render builds all defined images and shows the yamls that would be deployed",
+		Short: "Builds all defined images and shows the yamls that would be deployed",
 		Long: `
 #######################################################
 ################## devspace render #####################
diff --git a/cmd/run.go b/cmd/run.go
@@ -50,12 +50,12 @@ func NewRunCmd(f factory.Factory, globalFlags *flags.GlobalFlags, rawConfig *Raw
 	runCmd := &cobra.Command{
 		Use:                "run",
 		DisableFlagParsing: true,
-		Short:              "Run executes a predefined command",
+		Short:              "Executes a predefined command",
 		Long: `
 #######################################################
 ##################### devspace run ####################
 #######################################################
-Run executes a predefined command from the devspace.yaml
+Executes a predefined command from the devspace.yaml
 
 Examples:
 devspace run mycommand --myarg 123
diff --git a/cmd/set/set.go b/cmd/set/set.go
@@ -11,7 +11,7 @@ import (
 func NewSetCmd(f factory.Factory, globalFlags *flags.GlobalFlags, plugins []plugin.Metadata) *cobra.Command {
 	setCmd := &cobra.Command{
 		Use:   "set",
-		Short: "Make global configuration changes",
+		Short: "Sets global configuration changes",
 		Long: `
 #######################################################
 #################### devspace set #####################
diff --git a/cmd/upgrade.go b/cmd/upgrade.go
@@ -20,7 +20,7 @@ func NewUpgradeCmd() *cobra.Command {
 
 	upgradeCmd := &cobra.Command{
 		Use:   "upgrade",
-		Short: "Upgrade the DevSpace CLI to the newest version",
+		Short: "Upgrades the DevSpace CLI to the newest version",
 		Long: `
 #######################################################
 ################## devspace upgrade ###################
diff --git a/cmd/use/context.go b/cmd/use/context.go
@@ -27,7 +27,7 @@ func newContextCmd(f factory.Factory, globalFlags *flags.GlobalFlags) *cobra.Com
 #######################################################
 ############### devspace use context ##################
 #######################################################
-Switch the current kube context
+Switches the current kube-context
 
 Example:
 devspace use context my-context
diff --git a/cmd/use/namespace.go b/cmd/use/namespace.go
@@ -29,7 +29,7 @@ func newNamespaceCmd(f factory.Factory, globalFlags *flags.GlobalFlags) *cobra.C
 #######################################################
 ############## devspace use namespace #################
 #######################################################
-Set the default namespace to deploy to
+Sets the default namespace to deploy to
 
 Example:
 devspace use namespace my-namespace
diff --git a/cmd/use/use.go b/cmd/use/use.go
@@ -11,7 +11,7 @@ import (
 func NewUseCmd(f factory.Factory, globalFlags *flags.GlobalFlags, plugins []plugin.Metadata) *cobra.Command {
 	useCmd := &cobra.Command{
 		Use:   "use",
-		Short: "Use specific config",
+		Short: "Uses specific config",
 		Long: `
 #######################################################
 #################### devspace use #####################
diff --git a/dist/npm/index.js b/dist/npm/index.js
@@ -46,7 +46,7 @@ if (process.argv && process.argv.length > 2) {
   return;
 }
 
-if (action == "noop") {
+if (action === "noop") {
   console.log("Successfully ran noop command");
   process.exit(0);
 }
@@ -70,7 +70,7 @@ const getLatestVersion = function(callback, includePreReleases) {
     res,
     releasePage
   ) {
-    if (res.statusCode != 200) {
+    if (res.statusCode !== 200) {
       console.error(
         "Error requesting URL " +
           releasesURL +
@@ -93,7 +93,7 @@ const getLatestVersion = function(callback, includePreReleases) {
       "$1"
     );
 
-    if (releasePage != latestVersion && latestVersion) {
+    if (releasePage !== latestVersion && latestVersion) {
       callback(latestVersion);
     } else {
       console.error("Unable to identify latest devspace version");
@@ -102,7 +102,7 @@ const getLatestVersion = function(callback, includePreReleases) {
   });
 };
 
-if (action == "update-version") {
+if (action === "update-version") {
   getLatestVersion(function(latestVersion) {
     packageJson.version = latestVersion;
 
@@ -113,7 +113,7 @@ if (action == "update-version") {
   return;
 }
 
-if (action == "get-tag") {
+if (action === "get-tag") {
   getLatestVersion(function(latestVersion) {
     let tagRegex = /^.*-([a-z]*)(\.)?([0-9]*)?$/i
     let tag = "latest"
@@ -135,7 +135,7 @@ if (action == "get-tag") {
 function rimraf(dir_path) {
   if (fs.existsSync(dir_path)) {
       fs.readdirSync(dir_path).forEach(function(entry) {
-          var entry_path = path.join(dir_path, entry);
+          let entry_path = path.join(dir_path, entry);
           if (fs.lstatSync(entry_path).isDirectory()) {
               rimraf(entry_path);
           } else {
@@ -153,7 +153,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
   let downloadExtension = ".dl";
   let binaryName = packageJson.name;
 
-  if (platform == PLATFORM_MAPPING.win32) {
+  if (platform === PLATFORM_MAPPING.win32) {
     binaryName += ".exe";
   }
 
@@ -184,7 +184,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
   try {
     let yarnGlobalDir = normalizePath(path.join(execSync('yarn global dir').toString(), "node_modules"));
     let yarnLink = normalizePath(path.join(yarnGlobalDir, packageJson.name));
-    let yarnLinkExists = fs.existsSync(yarnLink) && yarnLink == packageDir;
+    let yarnLinkExists = fs.existsSync(yarnLink) && yarnLink === packageDir;
 
     if (yarnLinkExists || packageDir.startsWith(yarnGlobalDir)) {
       try {
@@ -199,7 +199,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
   try {
     let npmGlobalDir = normalizePath(execSync('npm root -g').toString());
     let npmLink = normalizePath(path.join(npmGlobalDir, packageJson.name));
-    let npmLinkExists = fs.existsSync(npmLink) && npmLink == packageDir;
+    let npmLinkExists = fs.existsSync(npmLink) && npmLink === packageDir;
 
     if (npmLinkExists || !globalDir || packageDir.startsWith(npmGlobalDir)) {
       try {
@@ -211,8 +211,8 @@ let continueProcess = function(askRemoveGlobalFolder) {
     }
   } catch(e) {}
   
-  if (globalDir == null) {
-    if (platform == PLATFORM_MAPPING.win32) {
+  if (globalDir === null) {
+    if (platform === PLATFORM_MAPPING.win32) {
       console.error("Error finding binary installation directory");
       process.exit(3);
     }
@@ -241,7 +241,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
   } catch (e) {}
 
   let removeScripts = function(allScripts) {
-    if (platform == PLATFORM_MAPPING.win32) {
+    if (platform === PLATFORM_MAPPING.win32) {
       if (allScripts) {
         try {
           fs.unlinkSync(binaryPath.replace(/\.exe$/i, ""));
@@ -255,10 +255,10 @@ let continueProcess = function(askRemoveGlobalFolder) {
     }
   }
   
-  if (action == "install") {
+  if (action === "install") {
     removeScripts(false);
 
-    if (platform == PLATFORM_MAPPING.win32) {
+    if (platform === PLATFORM_MAPPING.win32) {
       if (globalInstall) {
         // Remove bin/devspace.cmd file because it can cause issues
         try {
@@ -272,7 +272,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
       }
     }
   }
-  else if (action == "uninstall") {
+  else if (action === "uninstall") {
     try {
       fs.unlinkSync(binaryPath);
     } catch (e) {}
@@ -308,19 +308,19 @@ let continueProcess = function(askRemoveGlobalFolder) {
           },
         ])
         .then(answers => {
-          if (answers.checkRemoveGlobalFolder == "yes") {
+          if (answers.checkRemoveGlobalFolder === "yes") {
             removeGlobalFolder();
           }
         });
     } else {
       console.warn("DevSpace will not remove the global ~/.devspace folder without asking. This uninstall call is being executed in a non-interactive environment.")
     }
   } else {
-    if (action == "finish-install") {
+    if (action === "finish-install") {
       cleanPathVar = process.env.PATH.replace(/(^|;)[a-z]:/gi, path.delimiter).replace(/(\\)+/g, '/');
       cleanGlobalDir = globalDir.replace(/(^|;)[a-z]:/gi, '').replace(/(\\)+/g, '/').trimRight("/");
     
-      if (cleanPathVar.split(path.delimiter).indexOf(cleanGlobalDir) == -1 && cleanPathVar.split(path.delimiter).indexOf(cleanGlobalDir + "/") == -1) {
+      if (cleanPathVar.split(path.delimiter).indexOf(cleanGlobalDir) === -1 && cleanPathVar.split(path.delimiter).indexOf(cleanGlobalDir + "/") === -1) {
         console.error("\n\n################################################\nWARNING: npm binary directory NOT in $PATH environment variable: " + globalDir + "\n################################################\n\n");
     
         if (globalInstall) {
@@ -349,7 +349,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
           .replace("{{platform}}", platform)
           .replace("{{arch}}", arch);
 
-        if (platform == PLATFORM_MAPPING.win32) {
+        if (platform === PLATFORM_MAPPING.win32) {
           downloadPath += ".exe";
         }
 
@@ -376,15 +376,15 @@ let continueProcess = function(askRemoveGlobalFolder) {
             process.exit(6);
           })
           .on("response", function(res) {
-            if (res.statusCode != 200) {
+            if (res.statusCode !== 200) {
               writeStream.end();
               spinner.stop(true);
 
-              if (res.statusCode == 404) {
+              if (res.statusCode === 404) {
                 console.error("Release version " + version + " not found.\n");
 
                 getLatestVersion(function(latestVersion) {
-                  if (latestVersion != version) {
+                  if (latestVersion !== version) {
                     console.log(
                       "Downloading latest stable release instead. Latest version is: " +
                         latestVersion +
@@ -394,7 +394,6 @@ let continueProcess = function(askRemoveGlobalFolder) {
                     downloadRelease(latestVersion);
                   }
                 });
-                return;
               } else {
                 console.error(
                   "Error requesting URL " +
@@ -420,7 +419,7 @@ let continueProcess = function(askRemoveGlobalFolder) {
             spinner.stop(true);
 
             try {
-              fs.chmodSync(binaryPath + downloadExtension, 0755);
+              fs.chmodSync(binaryPath + downloadExtension, "0755");
             } catch (e) {
               console.error("Unable to chmod: " + e)
               showRootError();
@@ -446,10 +445,10 @@ let continueProcess = function(askRemoveGlobalFolder) {
 if (process.ppid > 1) {
   findProcess('pid', process.ppid)
     .then(function (list) {
-      if (list.length == 1 && list[0].ppid > 1) {
+      if (list.length === 1 && list[0].ppid > 1) {
         findProcess('pid', list[0].ppid)
           .then(function (list) {
-            if (list.length == 1 && /((npm-cli.js("|')\s+up(date)?)|(yarn.js("|')\s+(global\s+)?upgrade))\s+.*((\/)|(\\)|(\s))devspace((\/)|(\\)|(\s)|$)/.test(list[0].cmd)) {
+            if (list.length === 1 && /((npm-cli.js("|')\s+up(date)?)|(yarn.js("|')\s+(global\s+)?upgrade))\s+.*((\/)|(\\)|(\s))devspace((\/)|(\\)|(\s)|$)/.test(list[0].cmd)) {
               continueProcess(false);
             } else {
               continueProcess(true);

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func NewCompletionCmd() *cobra.Command {`
`43`	`43`	`return cobra.OnlyValidArgs(cmd, args)`
`44`	`44`	`},`
`45`	`45`	`ValidArgs: []string{"bash", "zsh"},`
`46`		`- Short: "Output shell completion for the given shell (bash or zsh)",`
	`46`	`+ Short: "Outputs shell completion for the given shell (bash or zsh)",`
`47`	`47`	`Long: longDescription,`
`48`	`48`	`RunE: completion,`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ func NewPurgeCmd(f factory.Factory, globalFlags flags.GlobalFlags, rawConfig R`
`17`	`17`	`}`
`18`	`18`	`purgeCmd := &cobra.Command{`
`19`	`19`	`Use: "purge",`
`20`		`- Short: "Delete deployed resources",`
	`20`	`+ Short: "Deletes deployed resources",`
`21`	`21`	Long: `
`22`	`22`	`#######################################################`
`23`	`23`	`################### devspace purge ####################`