added test for run_pipelines

Author: tukobadnyanoba

e2e/framework/helper.go

@@ -1,12 +1,14 @@
 package framework
 
 import (
+	"context"
 	"fmt"
 	"github.com/go-resty/resty/v2"
 	"github.com/loft-sh/devspace/e2e/kube"
 	"github.com/onsi/gomega"
 	"github.com/pkg/errors"
 	"io/ioutil"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"os"
 	"strings"
@@ -86,6 +88,21 @@ func ExpectLocalCurlContents(urlString string, contents string) {
 	ExpectNoErrorWithOffset(1, err)
 }
 
+func ExpectContainerNameAndImageEqual(namespace, deploymentName, containerImage, containerName string) {
+	kubeClient, err := kube.NewKubeHelper()
+	ExpectNoErrorWithOffset(1, err)
+	err = wait.PollImmediate(time.Second, time.Minute*2, func() (done bool, err error) {
+		deploy, err := kubeClient.RawClient().AppsV1().Deployments(namespace).Get(context.TODO(),
+			deploymentName, metav1.GetOptions{})
+		if err != nil {
+			return false, nil
+		}
+		return deploy.Spec.Template.Spec.Containers[0].Name == containerName &&
+			deploy.Spec.Template.Spec.Containers[0].Image == containerImage, nil
+	})
+	ExpectNoErrorWithOffset(1, err)
+}
+
 func ExpectRemoteCurlContents(imageSelector string, namespace string, urlString string, contents string) {
 	kubeClient, err := kube.NewKubeHelper()
 	ExpectNoErrorWithOffset(1, err)

e2e/tests/pipelines/pipelines.go

@@ -120,23 +120,38 @@ var _ = DevSpaceDescribe("pipelines", func() {
 		}
 	})
 
-	ginkgo.FIt("should get value from config", func() {
-		tempDir, err := framework.CopyToTempDir("tests/pipelines/testdata/getconfigvalue")
+	ginkgo.It("should use --set value from run_pipelines command", func() {
+		tempDir, err := framework.CopyToTempDir("tests/pipelines/testdata/run_pipelines")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
 
 		ns, err := kubeClient.CreateNamespace("pipelines")
 		framework.ExpectNoError(err)
 		defer framework.ExpectDeleteNamespace(kubeClient, ns)
 
-		devCmd := &cmd.RunPipelineCmd{
-			GlobalFlags: &flags.GlobalFlags{
-				NoWarn:    true,
-				Namespace: ns,
-			},
-			Pipeline: "dev",
-		}
-		err = devCmd.RunDefault(f)
+		done := make(chan error)
+		cancelCtx, cancel := context.WithCancel(context.Background())
+		defer cancel()
+
+		go func() {
+			defer ginkgo.GinkgoRecover()
+			devCmd := &cmd.RunPipelineCmd{
+				GlobalFlags: &flags.GlobalFlags{
+					NoWarn:     true,
+					Namespace:  ns,
+					ConfigPath: "devspace.yaml",
+				},
+				Pipeline: "dev",
+				Ctx:      cancelCtx,
+			}
+			done <- devCmd.RunDefault(f)
+		}()
+
+		// check if deployments are there
+		framework.ExpectContainerNameAndImageEqual(ns, "dev", "nginx", "mynginx")
+
+		cancel()
+		err = <-done
 		framework.ExpectNoError(err)
 	})
 

e2e/tests/pipelines/testdata/run_pipelines/devspace.yaml

@@ -0,0 +1,15 @@
+version: v2beta1
+name: run-pipelines-demo
+
+pipelines:
+  dev: |-
+    run_pipelines deploy --set deployments.dev.helm.values.containers[0].image=nginx --set-string deployments.dev.helm.values.containers[0].name=mynginx
+  deploy: |-
+    create_deployments --all
+
+deployments:
+  dev:
+    helm:
+      values:
+        containers:
+          - image: alpine