Skip to content

Commit e6cb7bb

Browse files
committed
Add screenshot code, update the CONTRIBUTING.md and fix clojure
1 parent 0fe65a0 commit e6cb7bb

5 files changed

Lines changed: 22 additions & 6 deletions

File tree

.github/scripts/build_assets/SeleniumRunner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ def upload_svgs(self, svgs: List[str]):
130130
self.test_for_possible_alert(self.SHORT_WAIT_IN_SEC, "Dismiss")
131131
self.remove_color_from_icon()
132132

133+
# take a screenshot of the icons that were just added
134+
self.driver.save_screenshot("new_icons.png");
133135
self.click_hamburger_input()
134136
select_all_button = WebDriverWait(self.driver, self.LONG_WAIT_IN_SEC).until(
135137
ec.element_to_be_clickable((By.XPATH, "//button[text()='Select All']"))

.github/workflows/build_icons.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,16 @@ jobs:
2727
./icomoon.json ./devicon.json ./icons ./ --headless
2828
- name: Upload geckodriver.log for debugging purposes
2929
uses: actions/upload-artifact@v2
30-
if: ${{always()}}
30+
if: ${{failure()}}
3131
with:
3232
name: geckodriver-log
3333
path: ./geckodriver.log
34+
- name: Upload screenshot of the newly made icons
35+
uses: actions/upload-artifact@v2
36+
if: ${{success()}}
37+
with:
38+
name: new_icons
39+
path: ./.github/scripts/new_icons.png
3440
- name: Running npm task for building devicon.min.css
3541
if: ${{ success() }}
3642
run: npm run build-css

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
157157
],
158158
"font": [ // here are the versions that are available as font icons
159159
"original", // original is simple enough to be used as plain
160-
"plain-wordmark"
160+
"plain-wordmark",
161+
"plain" // plain doesn't exist as an svg but it will be in the final font version
161162
]
162163
},
163164
"color": "#F7A80D", // note the '#' character

devicon.json

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,12 +387,20 @@
387387
"versions": {
388388
"svg": [
389389
"original",
390+
"line"
391+
],
392+
"font": [
390393
"line",
391394
"plain"
392-
],
393-
"font": []
395+
]
394396
},
395-
"aliases": []
397+
"color": "#5881d8",
398+
"aliases": [
399+
{
400+
"base": "line",
401+
"alias": "plain"
402+
}
403+
]
396404
},
397405
{
398406
"name": "clojurescript",

icons/clojure/clojure-plain.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)