Skip to content

Commit d7413b5

Browse files
Thomas-BoiThomas-Boi
committed
Updated CONTRIBUTING
1 parent 3544e15 commit d7413b5

1 file changed

Lines changed: 60 additions & 38 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 60 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ First of all, thanks for taking the time to contribute! This project can only gr
55

66
<h2>Table of Content</h2>
77
<ul>
8+
<li><a href="#terms">Terms</a></li>
89
<li><a href="#overview">Overview on Submitting Icon</a></li>
910
<li><a href="#versionNaming">Naming Conventions</a></li>
1011
<li><a href="#svgStandards">SVG Standards</a></li>
@@ -16,62 +17,83 @@ First of all, thanks for taking the time to contribute! This project can only gr
1617
</ul>
1718

1819
<hr>
19-
<h2 id="overview">Overview on Submitting Icon</h2>
20+
<h2 id="terms">Terms</h2>
21+
<p>Here are some terms that we will use in this repo: </p>
22+
<ol>
23+
<li>"Icon" refers to the set of svgs/icons of a technology/tool. Ex: We might refer to the React svgs and React icons as the React Icon</li>
24+
<li>"SVG/<code>.svg</code>" refers to the <code>svg</code> versions of the Icons.</li>
25+
<li>"icons" refers to the icon versions of the Icons.</li>
26+
</ol>
27+
28+
<hr>
29+
<h2 id="overview">Overview on Submitting Icons</h2>
2030
<p>Here is an overview of what you have to do to submit your icons to the repo.</p>
2131
<ol>
22-
<li>Create the svgs for each logo versions that you have </li>
23-
<li>Put the svgs for each logo into its own folders in <code>/icons</code> </li>
24-
<li><a href="#updateDevicon">Update the <code>devicon.json</code> to include the new icon</a> </li>
25-
<li>Create a separated pull request (PR) for each icon (no matter how many versions). </li>
26-
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
27-
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
32+
<li>Create the svgs for each <a href="#versionNaming"> svg versions </a> that you have</li>
33+
<li>Put the svgs of each Icon into its own folders in <code>/icons</code> </li>
34+
<li><a href="#updateDevicon">Update the <code>devicon.json</code> to include the new Icon</a> </li>
35+
<li>Create a separated pull request (PR) for each Icon. </li>
36+
<li>Include the name of the Icon in the pull request title in this format: <code>new icon: <i>Icon name</i> (<i>versions</i>)</code> </li>
37+
<li><i>Optional</i>: Add images of the new svg(s) to the description of the pull request. This would help speed up the review process </li>
2838
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
29-
<li>Wait for a repo maintainer to review your changes. They will run a script to check your icons. </li>
39+
<li>Wait for a maintainer to review your changes. They will run a script to check your icons.</li>
3040
<li>If there are no issue, they will accept your PR into the repo. Else, they will let you know and give you a chance to fix it.</li>
3141
</ol>
3242

3343
<hr>
3444
<h2 id='versionNaming'>Versions and Naming Conventions</h2>
35-
<p>Each icon can come in different versions. So far, we have:</p>
45+
<p>Each icon/svg can come in different versions. So far, we have:</p>
3646
<ul>
37-
<li><b>original</b>: the original logo. Can contains multiple colors. <a href="https://github.com/devicons/devicon/blob/master/icons/amazonwebservices/amazonwebservices-original.svg"> Example </a> </li>
47+
<li><b>original</b>: the original logo. Can contain multiple colors. <a href="https://github.com/devicons/devicon/blob/master/icons/amazonwebservices/amazonwebservices-original.svg"> Example </a> </li>
3848
<li><b>original-wordmark</b>: similar to the above but must contain the name of the technology.<a href="https://github.com/devicons/devicon/blob/master/icons/amazonwebservices/amazonwebservices-original-wordmark.svg"> Example </a></li>
3949
<li><b>plain</b>: a one-color version of the original logo.<a href="https://github.com/devicons/devicon/blob/master/icons/android/android-plain.svg"> Example </a></li>
4050
<li><b>plain-wordmark</b>: a one-color version of the original logo but with wordmark.<a href="https://github.com/devicons/devicon/blob/master/icons/android/android-plain-wordmark.svg"> Example </a></li>
4151
<li><b>line</b>: a one-color, line version of the original logo.<a href="https://github.com/devicons/devicon/blob/master/icons/apache/apache-line.svg"> Example </a></li>
4252
<li><b>line-wordmark</b>: a one-color, line version of the original logo but with wordmark.<a href="https://github.com/devicons/devicon/blob/master/icons/apache/apache-line-wordmark.svg"> Example </a></li>
4353
</ul>
44-
<p>
45-
It is not mandatory to have 6 versions for each icon. An icon can only have one or two versions available. Just keep in mind that the minimum is 1 and the maximum 6 (for now). You must also have at least one version that can be make into an icon.
46-
</p>
47-
<p>
48-
The <b>plain</b> and <b>line</b> versions (with or without wordmark) are designed to be available in the final icon font.
49-
</p>
50-
<p>
51-
The <b>original</b> version are only available in svg format, so they do not need to be as simple and can contain numerous colors.
52-
</p>
53-
<p>
54-
Some icons are really simple (like the Apple one), so the original version can be used as the plain version and as the icon font. In this case, you'll only need to make only one of the version (either "original" or "plain"). You can then add an alias in the <code>devicon.json</code> so they can be found with either the "original" or "plain" naming convention. Note that this only applies to font icon versions only, not the SVG versions. SVG versions don't need aliases.
55-
</p>
54+
<p> Notes <p>
55+
<ol>
56+
<li>
57+
It is not mandatory to have 6 versions for each icon. An icon can only have one or two versions available. Just keep in mind that the minimum is 1 and the maximum 6 (for now). You must also have at least one version that can be make into an icon.
58+
</li>
59+
<li>
60+
The <b>plain</b> and <b>line</b> versions (with or without wordmark) are designed to be available in the final icon font.
61+
</li>
62+
<li>
63+
The <b>original</b> version are only available in svg format, so they do not need to be as simple and can contain numerous colors.
64+
</li>
65+
<li>
66+
</li>
67+
<li>
68+
Some icons are really simple (like the Apple one), so the original version can be used as the plain version and as the icon font. In this case, you'll only need to make only one of the version (either "original" or "plain"). You can then add an alias in the <code>devicon.json</code> so they can be found with either the "original" or "plain" naming convention.
69+
70+
<ol>
71+
<li>
72+
This only applies to font icon versions only, not the SVG versions. SVG versions don't need aliases.
73+
</li>
74+
</ol>
75+
</li>
76+
</ol>
5677

5778
<hr>
5879
<h2 id='svgStandards'>SVG Standards</h2>
5980
<p>Before you submit your logos/svgs, please ensure that they meet the following standard:</p>
6081
<ul>
6182
<li>The background must be transparent.</li>
62-
<li>The <b>plain</b> and <b>line</b> versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united before exporting to svg.
83+
<li>The <b>plain</b> and <b>line</b> versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united before exporting to svg. We will strip the color when turning it into icons.
6384
</li>
6485
<li>Optimize/compress your SVGs. You can use a service like <a href="https://compressor.io/">compressor</a> or <a href="https://petercollingridge.appspot.com/svg-editor">SVG Editor</a>.</li>
65-
<li>The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its<a href="https://icomoon.io/#docs/stroke-to-fill"> requirements.</a></li>
86+
<li>The icon's strokes and texts must be fills. This is to satisfy our conversion website's <a href="https://icomoon.io/#docs/stroke-to-fill">requirements.</a></li>
6687
<li>Each <code>.svg</code> file contains one version of an icon in a <code>0 0 128 128</code> viewbox.</li>
67-
<li>The naming convention for the svg file is the following: <code>(icon name)-(original|plain|line)(-wordmark?).</code></li>
88+
<li>Each <code>.svg</code> must use the <code>fill</code> attribute instead of using <code>classes</code> for colors. See <a href="https://github.com/devicons/devicon/issues/407">here</a> for more details.</li>
89+
<li>The naming convention for the svg file is the following: <code>(Icon name)-(original|plain|line)(-wordmark?).</code></li>
6890
</ul>
6991

7092
<hr>
7193
<h2 id='orgGuidelines'>Organizational Guidelines</h2>
7294
<ul>
73-
<li>Each icon has its own folder located in the <code>icons</code> folder</li>
74-
<li>Each icon folder contains one <code>.eps</code> file and as many <code>.svg</code> files as versions available</li>
95+
<li>Each Icon has its own folder located in the <code>icons</code> folder</li>
96+
<li>Each Icon folder must contain one <code>.eps</code> file and as many <code>.svg</code> files as versions available (at the minimum one <code>.svg</code> file)</li>
7597
<li>The <code>.eps</code> file contains all available versions of an icon. Each version is contained in a 128px by 128px artboard</li>
7698
</ul>
7799

@@ -81,7 +103,7 @@ Some icons are really simple (like the Apple one), so the original version can b
81103
Before you open a PR into Devicon, you'd have to update the <code>devicon.json</code>. This is essential for our build script to work and to document your work.
82104
</p>
83105
<p>
84-
Here is the object that each of your logo must have:
106+
Here is the object that each of your Icon must have:
85107
</p>
86108

87109
<pre>
@@ -103,7 +125,7 @@ Some icons are really simple (like the Apple one), so the original version can b
103125
Here is what VersionString means:
104126
</p>
105127
<ol>
106-
<li> It's the version part of an `svg` file's name</li>
128+
<li> It's the version part of an <code>svg</code> file's name</li>
107129
<li> If you have "html5-original", the version string would be "original" </li>
108130
<li> If you have "react-line-wordmark", the version string would be "line-wordmark" </li>
109131
<li> See <a href="#versionNaming">naming conventions section</a> for more details </li>
@@ -127,19 +149,19 @@ Some icons are really simple (like the Apple one), so the original version can b
127149
As an example, let's assume you have created the svgs for Redhat and Amazon Web Services logos.
128150
</p>
129151
<p>For the Redhat svg, you have the "original", "original-wordmark", "plain", and "plain-wordmark" versions. </p>
130-
<p>For the Amazon Web Services svgs, you have the following versions: "original", "original-wordmark", "plain-wordmark". The "original" version is simple enough to be a "plain" version as well. Note that we are not using the acronym AWS.</p>
152+
<p>For the Amazon Web Services svgs, you have the "original", "original-wordmark", "plain-wordmark" versions. The "original" version is simple enough to be a "plain" version as well. Note that we are not using the acronym AWS.</p>
131153
<ol>
132154
<li>
133155
Put the svgs for each logo that you have into its own folders in <code>/icons</code>
134156
<ul>
135157
<li>This means you would create two folders: one for <code>amazonwebservices</code> and one for <code>redhat</code></li>
136-
<li><b>Note</b>: don't do this in the same commits. We want to have each logo in its own PR so don't create these two folders in the same commit</li>
158+
<li><b>Note</b>: don't do this in the same commits; we want to have each Icon in its own PR.</li>
137159
</ul>
138160
</li>
139161
<li>
140-
<a href="#updateDevicon">Update the <code>devicon.json</code> to include the icon (or variations)</a>
162+
<a href="#updateDevicon">Update the <code>devicon.json</code></a>
141163
<ul>
142-
<li>For the <code>redhat</code>, you would do this
164+
<li>For <code>redhat</code>, you would do this
143165
<pre>
144166
<code>
145167
{
@@ -200,18 +222,17 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
200222
</code>
201223
</pre>
202224
</li>
203-
<li><b>Note</b>: again, don't do this in the same commits. We want to have each logo in its own PR so don't create two folders in the same commit</li>
204225
</ul>
205226
</li>
206-
<li>Create a separate pull request (PR) for each icon (no matter how many variations).
227+
<li>Create a separate pull request (PR) for each Icon.
207228
<ul>
208229
<li>This means you would have to create two PRs</li>
209230
<li>For Amazon Web Services, the branch name would be icons/amazonwebservices. </li>
210231
<li>For Redhat, the branch name would be icons/redhat. </li>
211232
</ul>
212233
</li>
213234
<li>
214-
Include the name of the icon in the pull request. Follow this format: "new icon: {{logoName}} ({{versions}})"
235+
Include the name of the icon in the pull request. Follow this format: "new icon: <i>Icon name</i> (<i>versions</i>}})"
215236
<ul>
216237
<li>For Amazon Web Services, your PR title should be "new icon: amazonwebservices (original, original-wordmark, plain-wordmark)"</li>
217238
<li>For Redhat, your PR title should be "new icon: redhat (original, original-wordmark, plain, plain-wordmark)"</li>
@@ -222,7 +243,7 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
222243

223244
<hr>
224245
<h2 id='requestingIcon'>Requesting an Icon</h2>
225-
<p>When you want to request a new icon please feel free to create a issue following some simple guidelines:</p>
246+
<p>To request an icon, you can create an issue in the repo. Please follow these simple guidelines:</p>
226247
<ul>
227248
<li>Search for other issues already requesting the icon</li>
228249
<li>If an issue doesn't exist, create an issue naming it "Icon request: <i>name-of-the-icon</i>". </li>
@@ -241,5 +262,6 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
241262
<p>There are also other tasks that we are automating, such as:</p>
242263
<ul>
243264
<li>Ensure code quality is up to standard</li>
244-
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot for check.
265+
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot to check that it looks good.
266+
<li>Comment on the PR so maintainers don't have to manually upload icon result.</li>
245267
</ul>

0 commit comments

Comments
 (0)