You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+7-4Lines changed: 7 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -26,9 +26,8 @@ First of all, thanks for taking the time to contribute! This project can only gr
26
26
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
27
27
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
28
28
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
29
-
<li>Wait for a repo maintainer to review your changes. Once they are satisfied, they will <ahref="#buildScript">build your repo </a>. This will create a PR into your branch.</li>
30
-
<li>Review the PR. It should contain the icon versions of your svgs. Accept the changes if you are satisfied</li>
31
-
<li>Once you accept the changes, a maintainer will accept your PR into the repo.</li>
29
+
<li>Wait for a repo maintainer to review your changes. They will run a script to check your icons. </li>
30
+
<li>If there are no issue, they will accept your PR into the repo. Else, they will let you know and give you a chance to fix it.</li>
32
31
</ol>
33
32
34
33
<hr>
@@ -233,9 +232,13 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
233
232
<hr>
234
233
<h2id='buildScript'>Regarding The Build Script</h2>
235
234
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>
236
-
<p>So far, the tasks that we have automated are:</p>
235
+
<p>So far, the tasks in the build script are:</p>
237
236
<ul>
238
237
<li>Upload svgs to <ahref="https://icomoon.io/app/#/select">icomoon.io</a> and get the icons back. For details, see <ahref="https://github.com/devicons/devicon/issues/252"> the original disscussion</a>, <ahref="https://github.com/devicons/devicon/pull/268">this PR that introduce the feature</a> and <ahref="https://github.com/devicons/devicon/issues/300">the final changes to it.</a></li>
239
238
<li>Build, combine, and minify CSS files. For details, see <ahref="https://github.com/devicons/devicon/pull/290">this</a></li>
239
+
</ul>
240
+
<p>There are also other tasks that we are automating, such as:</p>
241
+
<ul>
240
242
<li>Ensure code quality is up to standard</li>
243
+
<li>Upload svgs to <ahref="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot for check.
0 commit comments