Skip to content

Commit cc4266e

Browse files
committed
Build script now run manually
1 parent c76ba93 commit cc4266e

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

.github/workflows/build_icons.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
name: Build Icons
2-
on:
3-
pull_request:
4-
types: [labeled]
2+
on: workflow_dispatch
53
jobs:
64
build:
75
name: Get Fonts From Icomoon
8-
if: contains(github.event.pull_request.labels.*.name, 'bot:build')
96
runs-on: windows-2019
107
steps:
118
- uses: actions/checkout@v2
@@ -46,7 +43,8 @@ jobs:
4643
uses: peter-evans/create-pull-request@v3
4744
with:
4845
branch: ${{ format('build/{0}', github.head_ref) }}
46+
base: 'develop'
4947
commit-message: 'Built new icons, icomoon.json and devicon.css'
5048
title: 'bot:build new icons, icomoon.json and devicon.css'
5149
body: 'Automated font-building task ran by GitHub Actions bot'
52-
delete-branch: ${{true}}
50+
delete-branch: true

CONTRIBUTING.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ First of all, thanks for taking the time to contribute! This project can only gr
2626
<li>Include the name of the icon in the pull request title. Follow this format: <code>new icon: {{logoName}} ({{versions}})</code> </li>
2727
<li><i>Optional</i>: Add images of the new icon(s) to the description of the pull request. This would help speed up the review process </li>
2828
<li><i>Optional</i>: Reference the issues regarding the new icon. </li>
29-
<li>Wait for a repo maintainer to review your changes. Once they are satisfied, they will <a href="#buildScript">build your repo </a>. This will create a PR into your branch.</li>
30-
<li>Review the PR. It should contain the icon versions of your svgs. Accept the changes if you are satisfied</li>
31-
<li>Once you accept the changes, a maintainer will accept your PR into the repo.</li>
29+
<li>Wait for a repo maintainer to review your changes. They will run a script to check your icons. </li>
30+
<li>If there are no issue, they will accept your PR into the repo. Else, they will let you know and give you a chance to fix it.</li>
3231
</ol>
3332

3433
<hr>
@@ -233,9 +232,13 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
233232
<hr>
234233
<h2 id='buildScript'>Regarding The Build Script</h2>
235234
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>
236-
<p>So far, the tasks that we have automated are:</p>
235+
<p>So far, the tasks in the build script are:</p>
237236
<ul>
238237
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and get the icons back. For details, see <a href="https://github.com/devicons/devicon/issues/252"> the original disscussion</a>, <a href="https://github.com/devicons/devicon/pull/268">this PR that introduce the feature</a> and <a href="https://github.com/devicons/devicon/issues/300">the final changes to it.</a></li>
239238
<li>Build, combine, and minify CSS files. For details, see <a href="https://github.com/devicons/devicon/pull/290">this</a></li>
239+
</ul>
240+
<p>There are also other tasks that we are automating, such as:</p>
241+
<ul>
240242
<li>Ensure code quality is up to standard</li>
243+
<li>Upload svgs to <a href="https://icomoon.io/app/#/select">icomoon.io</a> and take a screenshot for check.
241244
</ul>

0 commit comments

Comments
 (0)