Skip to content

Commit 9dcbf70

Browse files
authored
Improve/fix the pull request template (#803)
1 parent 0053ce0 commit 9dcbf70

1 file changed

Lines changed: 18 additions & 25 deletions

File tree

.github/pull_request_template.md

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,38 @@
1-
---
2-
name: Pull Request Template
3-
about: Add a new icon or feature to the repo.
4-
title: 'New Icon/Feature: [NAME]'
5-
assignees: ''
6-
7-
---
8-
# New Icon Section
1+
# **New icon section**
92

10-
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. -->
3+
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New feature** section below. -->
114

125
## Double check these details before you open a PR
136

147
<!-- Tick the checkboxes to ensure you've done everything correctly -->
15-
- [] PR does not match another non-stale PR currently opened
16-
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
17-
- [] PR's base is the `develop` branch.
18-
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
19-
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
20-
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
8+
- [ ] PR does not match another non-stale PR currently opened
9+
- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
10+
- [ ] The PR's base is the `develop` branch.
11+
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
12+
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
13+
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
2114

22-
<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
15+
<!-- Refer to the contributing guidelines for more details https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon -->
16+
17+
## Link to prove your SVG is correct and up-to-date
2318

24-
## Link to prove your SVG is correct and up-to-date.
2519
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->
2620

2721
---
28-
# New Feature Section
22+
# **New feature section**
2923

30-
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. -->
24+
<!-- If you are adding a new feature, follow the steps listed here, and delete the **New icon** section above. -->
3125

32-
## Double check these details before you open a PR**
26+
## Double check these details before you open a PR
3327

3428
<!-- Tick the checkboxes to ensure you've done everything correctly -->
35-
- [] PR does not match another non-stale PR currently opened
36-
- [] PR name matches the format *New Feature: brief description of feature*
37-
29+
- [ ] PR does not match another non-stale PR currently opened
30+
- [ ] PR name matches the format *New Feature: a brief description of feature*
3831

39-
## This PR adds/fixes...
32+
## This PR adds/fixes
4033

4134
<!-- List your features here and the benefits they bring. -->
4235

4336
## Notes
4437

45-
<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->
38+
<!-- List anything note-worthy here (potential issues, this needs to be merged to `develop` before working, etc.). -->

0 commit comments

Comments
 (0)