Skip to content

Commit 92417d4

Browse files
Feature/website cache busting (#813)
* Feature: Cache busting website data (JavaScript and SVG files) by adding '?version' to these filenames * Updated script.js to use CDN versioning style * Cache busting script.js as well, to load cache busting changes * Website cache busting fix * Cache busting script.js using Date.now() Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
1 parent 0c061e1 commit 92417d4

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

docs/assets/js/script.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ devicon.controller('IconListCtrl', function($scope, $http, $compile) {
2424
console.log('Unable to determine latest release version, fallback to master.')
2525
});
2626

27-
28-
var baseUrl = `https://cdn.jsdelivr.net/gh/${gitHubPath}/`
27+
var versionStr = '@' + $scope.latestReleaseTagging;
28+
var baseUrl = `https://cdn.jsdelivr.net/gh/${gitHubPath}${versionStr}/`
2929

3030
// Get devicon.json
31-
$http.get(baseUrl + '/devicon.json').success(function(data) {
31+
$http.get(baseUrl + 'devicon.json').success(function(data) {
3232

3333
/*
3434
| Re-format devicon.json
@@ -126,7 +126,7 @@ devicon.controller('IconListCtrl', function($scope, $http, $compile) {
126126
*/
127127
$scope.selectSvg = function(svgVersion, index) {
128128

129-
$http.get(baseUrl + '/icons/' + $scope.selectedIcon.name + '/' + $scope.selectedIcon.name + '-' + svgVersion + '.svg').success(function(data){
129+
$http.get(baseUrl + 'icons/' + $scope.selectedIcon.name + '/' + $scope.selectedIcon.name + '-' + svgVersion + '.svg').success(function(data){
130130

131131
var svgElement = angular.element(data);
132132
var innerSvgElement = null;

docs/index.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,10 @@ <h3 class="cbp-ig-title">{{icon.name}}</h3>
135135
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.19/angular.min.js"></script>
136136
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.19/angular-sanitize.min.js"></script>
137137
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.19/angular-animate.min.js"></script>
138-
<script src="assets/js/script.js"></script>
138+
139+
<script>
140+
document.write("<script src='assets/js/script.js?" + Date.now() + "'><\/script>");
141+
</script>
139142

140143
<script>
141144
(function(i, s, o, g, r, a, m) {

0 commit comments

Comments
 (0)