Skip to content

Commit 4001786

Browse files
committed
Fixed an error where last commit didn't have desired changes
1 parent 4854e82 commit 4001786

2 files changed

Lines changed: 2 additions & 19 deletions

File tree

.github/workflows/peek_icons.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,4 @@ jobs:
3737
if: ${{success()}}
3838
with:
3939
name: new_icons
40-
path: ./new_icons.png
41-
- name: Pull Request Add Comment
42-
uses: actions/github-script@0.3.0
43-
env:
44-
message: >
45-
Hi! I'm Devicons' GitHub Actions Bot!
46-
47-
I just peeked at the icons that you wanted to add and upload them to the
48-
[Actions page](https://github.com/devicons/devicon/actions). The maintainers
49-
will now take a look at it and decide whether to merge your PR.
50-
51-
Cheers :),
52-
Bot
53-
with:
54-
github-token: ${{ secrets.GITHUB_TOKEN }}
55-
script: |
56-
const { issue: { number: pr_number }, repo: { owner, repo } } = context;
57-
github.issues.createComment({ pr_number, owner, repo, body: '$message' });
40+
path: ./new_icons.png

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Some icons are really simple (like the Apple one), so the original version can b
6363
<li>The <b>plain</b> and <b>line</b> versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united before exporting to svg.
6464
</li>
6565
<li>Optimize/compress your SVGs. You can use a service like <a href="https://compressor.io/">compressor</a> or <a href="https://petercollingridge.appspot.com/svg-editor">SVG Editor</a>.</li>
66-
<li>
66+
<li>The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its<a href="https://icomoon.io/#docs/stroke-to-fill"> requirements</a></li>
6767
</ul>
6868

6969
<hr>

0 commit comments

Comments
 (0)