Skip to content

Commit 377c739

Browse files
authored
Merge pull request #281 from amacado/master
Enhancing build scripts (bugfixing, documentation, introducing gulp, cleanup)
2 parents 77460c3 + 3788400 commit 377c739

18 files changed

Lines changed: 1655 additions & 1337 deletions

File tree

.github/scripts/build_assets/filehandler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def get_svgs_paths(new_icons: List[dict], icons_folder_path: str) -> List[str]:
6363
try:
6464
aliases = icon_info["aliases"]
6565
except KeyError:
66-
continue
66+
aliases = [] # create empty list of aliases if not provided in devicon.json
6767

6868
for font_version in icon_info["versions"]["font"]:
6969
if is_alias(font_version, aliases):
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
This folder was taken from: https://github.com/mozilla/geckodriver/releases/tag/v0.27.0
1+
## geckodriver
2+
Proxy for using W3C WebDriver compatible clients to interact with Gecko-based browsers.
3+
This program provides the HTTP API described by the WebDriver protocol to communicate with Gecko browsers, such as Firefox.
4+
It translates calls into the Marionette remote protocol by acting as a proxy between the local- and remote ends.
5+
6+
This application was taken from: https://github.com/mozilla/geckodriver/releases/tag/v0.27.0

.github/scripts/icomoon_upload.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ def main():
4343
print("No files need to be uploaded. Ending script...")
4444
return
4545

46+
# print list of new icons, separated by comma
47+
print("List of new icons:")
48+
print(*new_icons, sep = "\n")
4649
try:
4750
runner = SeleniumRunner(args.icomoon_json_path, args.download_path,
4851
args.geckodriver_path, args.headless)

.github/workflows/build_icons.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@ jobs:
1414
- uses: actions/checkout@v2
1515
with:
1616
ref: ${{ github.head_ref }}
17-
- name: Set up Python 3.8
17+
- name: Setup Python v3.8
1818
uses: actions/setup-python@v2
1919
with:
2020
python-version: 3.8
21-
- name: Install dependencies
21+
- name: Install dependencies (python, pip, npm)
2222
run: |
2323
python -m pip install --upgrade pip
2424
pip install -r ./.github/scripts/requirements.txt
25+
npm install
2526
- name: Run icomoon_upload.py
2627
run: >
2728
python ./.github/scripts/icomoon_upload.py
@@ -30,9 +31,12 @@ jobs:
3031
- name: Upload geckodriver.log for debugging purposes
3132
uses: actions/upload-artifact@v2
3233
with:
34+
name: geckodriver-log
3335
path: ./geckodriver.log
36+
- name: Running gulp default task for building devicon.min.css
37+
run: |
38+
gulp default
3439
- name: Commit changes
3540
uses: stefanzweifel/git-auto-commit-action@v4
3641
with:
37-
commit_message: Built new icons, icomoon.json and devicon.css
38-
branch: build-integrate
42+
commit_message: Build new icons, icomoon.json and devicon.css

0 commit comments

Comments
 (0)