Skip to content

Commit 22643eb

Browse files
committed
Fixed issue with alias and color in devicon.json
1 parent f10869a commit 22643eb

2 files changed

Lines changed: 10 additions & 12 deletions

File tree

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ Some icons are really simple (like the Apple one), so the original version can b
6262
<li>The <b>plain</b> and <b>line</b> versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united before exporting to svg.
6363
</li>
6464
<li>Optimize/compress your SVGs. You can use a service like <a href="https://compressor.io/">compressor</a> or <a href="https://petercollingridge.appspot.com/svg-editor">SVG Editor</a>.</li>
65-
<li>The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its<a href="https://icomoon.io/#docs/stroke-to-fill"> requirements</a></li>
66-
<li>Each <code>.svg</code> file contains one version of an icon in a <code>0 0 128 128</code> viewbox</li>
67-
<li>The naming convention for the svg file is the following: <code>(icon name)-(original|plain|line)-(wordmark)</code></li>
65+
<li>The icon's strokes and texts must be fills. We use Icomoon to make our icon, which has its<a href="https://icomoon.io/#docs/stroke-to-fill"> requirements.</a></li>
66+
<li>Each <code>.svg</code> file contains one version of an icon in a <code>0 0 128 128</code> viewbox.</li>
67+
<li>The naming convention for the svg file is the following: <code>(icon name)-(original|plain|line)(-wordmark?).</code></li>
6868
</ul>
6969

7070
<hr>
@@ -87,7 +87,7 @@ Some icons are really simple (like the Apple one), so the original version can b
8787
<pre>
8888
<code>
8989
{
90-
"name": string, // the official name of the technology. Must be lower case, no space or use the dash '-' character.
90+
"name": string, // the official name of the technology. Must be lower case, no space and don't have the dash '-' character.
9191
"tags": string[], // list of tags relating to the technology for search purpose
9292
"versions": {
9393
"svg": VersionString[], // list the svgs that you have
@@ -115,6 +115,7 @@ Some icons are really simple (like the Apple one), so the original version can b
115115
Here is what VersionString means:
116116
</p>
117117
<ol>
118+
<li> It's the version part of an `svg` file's name</li>
118119
<li> If you have "html5-original", the version string would be "original" </li>
119120
<li> If you have "react-line-wordmark", the version string would be "line-wordmark" </li>
120121
<li> See <a href="#versionNaming">Icon Formats and Naming Conventions</a> for more details </li>
@@ -126,7 +127,7 @@ Some icons are really simple (like the Apple one), so the original version can b
126127
As an example, let's assume you have created the svgs for Amazon Web Services and Redhat logos.
127128
</p>
128129
<p>For the Amazon Web Services svgs, you have the following versions: "original", "original-wordmark", "plain-wordmark". However, the "original" version is simple enough to be a "plain" version as well. Note that we are not using the acronym AWS.</p>
129-
<p>For the Redhat svg, you have the "original", "original-wordmark", "plain", "plain-wordmark" versions. </p>
130+
<p>For the Redhat svg, you have the "original", "original-wordmark", "plain", and "plain-wordmark" versions. </p>
130131
<ol>
131132
<li>
132133
Put the svgs for each logo that you have into its own folders in <code>/icons</code>
@@ -201,12 +202,11 @@ As an example, let's assume you have created the svgs for Amazon Web Services an
201202
<li><b>Note</b>: again, don't do this in the same commits. We want to have each logo in its own PR so don't create two folders in the same commit</li>
202203
</ul>
203204
</li>
204-
<li>Create a separated pull request (PR) for each icon (no matter how many variations).
205+
<li>Create a separate pull request (PR) for each icon (no matter how many variations).
205206
<ul>
206207
<li>This means you would have to create two PRs</li>
207208
<li>For Amazon Web Services, the branch name would be icons/amazonwebservices. </li>
208209
<li>For Redhat, the branch name would be icons/redhat. </li>
209-
<li> </li>
210210
</ul>
211211
</li>
212212
<li>

devicon.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -523,15 +523,12 @@
523523
"line-wordmark"
524524
],
525525
"font": [
526-
"line"
526+
"line",
527+
"line-wordmark"
527528
]
528529
},
529530
"color": "#000000",
530531
"aliases": [
531-
{
532-
"base": "original",
533-
"alias": "original-wordmark"
534-
},
535532
{
536533
"base": "line",
537534
"alias": "plain"
@@ -2257,6 +2254,7 @@
22572254
"original"
22582255
]
22592256
},
2257+
"color": "#764abc",
22602258
"aliases": [
22612259
{
22622260
"base": "original",

0 commit comments

Comments
 (0)