Skip to content

Commit 061993f

Browse files
committed
Merge branch 'master' of https://github.com/maltejur/devicon
2 parents 8126376 + 7e51ef1 commit 061993f

6 files changed

Lines changed: 54 additions & 5 deletions

File tree

.github/scripts/icomoon_peek.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def main():
2424
if len(filtered_icons) == 0:
2525
message = "No icons found matching the icon name in the PR's title.\n" \
2626
"Ensure that a new icon entry is added in the devicon.json and the PR title matches the convention here: \n" \
27-
"https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md#overview.\n" \
27+
"https://github.com/devicons/devicon/blob/master/CONTRIBUTING.md#overview\n" \
2828
"Ending script...\n"
2929
sys.exit(message)
3030

.github/workflows/build_icons.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ jobs:
6565
Adios,
6666
Build Bot :sunglasses:
6767
with:
68-
branch: 'master-build-result'
69-
base: 'master'
68+
branch: 'bot/build-result'
7069
commit-message: 'Built new icons, icomoon.json and devicon.css'
7170
title: 'bot:build new icons, icomoon.json and devicon.css'
7271
body: ${{ format(env.MESSAGE, fromJSON(steps.imgur_step.outputs.imgur_urls)[0] ) }}

CONTRIBUTING.md

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,15 @@ First of all, thanks for taking the time to contribute! This project can only gr
1616
<li><a href="#teams">Maintainer/Reviewer/Teams</a></li>
1717
<li><a href="#buildScript">Regarding the Build Script</a></li>
1818
<li><a href="#discordServer">Discord server</a></li>
19+
<li><a href="#release">Release strategy, conventions, preparation and execution</a></li>
1920
</ul>
2021

2122
<hr>
2223
<h2 id="terms">Terms</h2>
2324
<p>Here are some terms that we will use in this repo: </p>
2425
<ol>
2526
<li>"Technology" is used to describe a software, libraries, tool, etc...</li>
26-
<li>"Icon" refers to the svgs and icons version of a technology as a whole.</i>
27+
<li>"Icon" refers to the svgs and icons version of a technology as a whole.</li>
2728
<li>"SVG/<code>svg</code>" refers to the <code>svg</code> versions of the Icons.</li>
2829
<li>"icon" (lowercase) refers specficially to the font icon versions of the Icons.</li>
2930
</ol>
@@ -311,5 +312,33 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
311312
<h2 id="discordServer">Discord server</h2>
312313
<p>
313314
We are running a Discord server. You can go here to talk, discuss, and more with the maintainers and other people, too. Here's the invitation: https://discord.gg/hScy8KWACQ. If you don't have a GitHub account but want to suggest ideas or new icons, you can do that here in our Discord channel.
314-
<b>Note that the Discord server is unofficial, and Devicons is still being maintained via GitHub.<b>
315+
<b>Note that the Discord server is unofficial, and Devicons is still being maintained via GitHub.</b>
315316
</p>
317+
318+
<h2 id='release'>Release strategy, conventions, preparation and execution</h2>
319+
<h5>Release strategy</h5>
320+
<p>Devicon does not follow a strict release plan. A new release is depended on current amount of contributions, required bugfixes/patches and will be discussed by the team of maintainers.</p>
321+
<p>Generally speaking: A new release will be published when new icons are added or a bug was fixed. When it's predictable that multiple icons are added in a foreseeable amount of time they are usually wrapped together.</p>
322+
<h5>Conventions</h5>
323+
<p>The version naming follows the rules of <a href="https://semver.org/">Semantic Versioning</a>. Given a version number MAJOR.MINOR.PATCH, increment the:</p>
324+
<ul>
325+
<li>MAJOR version when you make incompatible API changes,</li>
326+
<li>MINOR version when you add functionality <b>(like a new icon)</b> in a backwards compatible manner, and</li>
327+
<li>PATCH version when you make backwards compatible bug fixes.</li>
328+
</ul>
329+
330+
<h5>Release preparation and execution</h5>
331+
<ol>
332+
<li>Define the next release version number based on the conventions</li>
333+
<li>Checkout <code>development</code> as <code>draft-release</code> branch</li>
334+
<li>Bump the package version using <code>npm version v<i>MAJOR</i>.<i>MINOR</i>.<i>PATCH</i> -m "bump npm version to v<i>MAJOR</i>.<i>MINOR</i>.<i>PATCH</i>"</code> (see <code><a href="https://github.com/devicons/devicon/pull/497">#487</a></code>)</li>
335+
<li>Push the branch <code>draft-release</code></li>
336+
<li>Manually trigger the workflow <code><a href="https://github.com/devicons/devicon/actions/workflows/build_icons.yml">build_icons.yml</a></code> (which has a <code>workflow_dispatch</code> event trigger) and select the branch <code>draft-release</code> as target branch. This will build a font version of all icons using icomoon and automatically creates a pull request to merge the build result back into <code>draft-release</code></li>
337+
<li>Review and approve the auto-create pull request created by the action of the step above</li>
338+
<li>Create a pull request towards <code>development</code>. Mention the release number in the pull request title and add information about all new icons, fixes, features and enhancements in the description of the pull request. Take the commits as a guideline. It's also a good idea to mention and thank all contributions who participated in the release (take description of <code><a href="https://github.com/devicons/devicon/pull/504">#504</a></code> as an example).</li>
339+
<li>Wait for review and approval of the pull request (<b>DON'T</b> perform a squash-merge)</li>
340+
<li>Once merged create a pull request with BASE <code>master</code> and HEAD <code>development</code>. Copy the description of the earlier pull request.</li>
341+
<li>Since it was already approved in the 'development' stage a maintainer is allowed to merge it (<b>DON'T</b> perform a squash-merge).</li>
342+
<li>Create a <a href="https://github.com/devicons/devicon/releases/new">new release</a> using v<i>MAJOR</i>.<i>MINOR</i>.<i>PATCH</i> as tag and release title. Use the earlier created description as description of the release.</li>
343+
<li>Publishing the release will trigger the <a href="/.github/workflows/npm_publish.yml">npm_publish.yml</a> workflow which will execute a <code>npm publish</code> leading to a updated <a href="https://www.npmjs.com/package/devicon">npm package</a> (v<i>MAJOR</i>.<i>MINOR</i>.<i>PATCH</i>).</li>
344+
</ol>

devicon.json

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,6 +1386,25 @@
13861386
"color": "#E24329",
13871387
"aliases": []
13881388
},
1389+
{
1390+
"name": "gitter",
1391+
"tags": [
1392+
"social",
1393+
"chat"
1394+
],
1395+
"versions": {
1396+
"svg": [
1397+
"plain",
1398+
"plain-wordmark"
1399+
],
1400+
"font": [
1401+
"plain",
1402+
"plain-wordmark"
1403+
]
1404+
},
1405+
"color": "#000000",
1406+
"aliases": []
1407+
},
13891408
{
13901409
"name": "go",
13911410
"tags": [
Lines changed: 1 addition & 0 deletions
Loading

icons/gitter/gitter-plain.svg

Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)