Skip to content

Commit e640acc

Browse files
committed
Update outdated comments
1 parent 121b4c9 commit e640acc

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

dataikuapi/dss/flow.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def _get_object_from_graph_node(self, node):
179179
def get_items_in_traversal_order(self, as_type="dict"):
180180
ret = []
181181
def add_to_set(node):
182-
print("*** Adding: %s" % node["ref"])
182+
#print("*** Adding: %s" % node["ref"])
183183
ret.append(node)
184184
def in_set(obj):
185185
for candidate in ret:
@@ -189,20 +189,18 @@ def in_set(obj):
189189

190190
def add_from(graph_node):
191191
#print("Add from %s" % graph_node["ref"])
192-
# To keep traversal order, we add predecessors before successors. And we recurse before adding
193-
# our own predecessors
192+
# To keep traversal order, we recurse to predecessors first
194193
for predecessor_ref in graph_node["predecessors"]:
195194
#print(" Pred = %s " % predecessor_ref)
196195
predecessor_node = self.nodes[predecessor_ref]
197196
if not in_set(predecessor_node):
198197
add_from(predecessor_node)
199198

200-
# Then ourselves
201-
#print(" Itself %s" % graph_node["ref"])
199+
# Then add ourselves
202200
if not in_set(graph_node):
203201
add_to_set(graph_node)
204202

205-
# For successors, we first add ourselves before successors
203+
# Then recurse to successors
206204
for successor_ref in graph_node["successors"]:
207205
#print(" Succ = %s " % successor_ref)
208206
successor_node = self.nodes[successor_ref]

0 commit comments

Comments
 (0)