Skip to content

Commit 1c6fd9b

Browse files
Really ignore all checked invalid input in HyperparameterSearchSettings setters
Co-authored-by: Adrien Lavoillotte <adrien.lavoillotte@dataiku.com>
1 parent d155fb4 commit 1c6fd9b

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

dataikuapi/dss/ml.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,7 @@ def set_kfold_validation(self, n_folds=5, stratified=True):
471471
if not (isinstance(n_folds, int) and n_folds > 0):
472472
warnings.warn("HyperparameterSearchSettings.set_kfold_validation ignoring invalid input: n_folds")
473473
warnings.warn("n_folds must be a positive integer")
474+
else:
474475
self._raw_settings["nFolds"] = n_folds
475476
if stratified is not None:
476477
if not isinstance(stratified, bool):
@@ -496,7 +497,8 @@ def set_single_split_validation(self, split_ratio=0.8, stratified=True):
496497
if not (isinstance(split_ratio, float) and split_ratio > 0 and split_ratio < 1):
497498
warnings.warn("HyperparameterSearchSettings.set_single_split_validation ignoring invalid input: split_ratio")
498499
warnings.warn(" split_ratio must be float between 0 and 1")
499-
self._raw_settings["splitRatio"] = split_ratio
500+
else:
501+
self._raw_settings["splitRatio"] = split_ratio
500502
if stratified is not None:
501503
if not isinstance(stratified, bool):
502504
warnings.warn("HyperparameterSearchSettings.set_single_split_validation ignoring invalid input: stratified")
@@ -516,7 +518,8 @@ def set_custom_validation(self, code=None):
516518
if not isinstance(code, string_types):
517519
warnings.warn("HyperparameterSearchSettings.set_custom_validation ignoring invalid input: code")
518520
warnings.warn("code must be a Python interpretable string")
519-
self._raw_settings["code"] = code
521+
else:
522+
self._raw_settings["code"] = code
520523
return self
521524

522525
def set_search_distribution(self, distributed=False, n_containers=4):

0 commit comments

Comments
 (0)