Remove unused mixin for regexs

Author: Sergey Vasilyev

data_diff/abcs/mixins.py

@@ -134,12 +134,6 @@ def list_tables(self, table_schema: str, like: Compilable = None) -> Compilable:
         """
 
 
-class AbstractMixin_Regex(AbstractMixin):
-    @abstractmethod
-    def test_regex(self, string: Compilable, pattern: Compilable) -> Compilable:
-        """Tests whether the regex pattern matches the string. Returns a bool expression."""
-
-
 class AbstractMixin_RandomSample(AbstractMixin):
     @abstractmethod
     def random_sample_n(self, tbl: str, size: int) -> str:

data_diff/databases/base.py

@@ -27,7 +27,7 @@
     Join, \
     Param, \
     Random, \
-    Root, TableAlias, TableOp, TablePath, TestRegex, \
+    Root, TableAlias, TableOp, TablePath, \
     TimeTravel, TruncateTable, UnaryOp, WhenThen, _ResolveColumn
 from data_diff.abcs.database_types import (
     AbstractDatabase,
@@ -52,7 +52,7 @@
     Boolean,
     JSON,
 )
-from data_diff.abcs.mixins import AbstractMixin_Regex, AbstractMixin_TimeTravel, Compilable
+from data_diff.abcs.mixins import AbstractMixin_TimeTravel, Compilable
 from data_diff.abcs.mixins import (
     AbstractMixin_Schema,
     AbstractMixin_RandomSample,
@@ -225,8 +225,6 @@ def render_compilable(self, c: Compiler, elem: Compilable) -> str:
             return self.render_checksum(c, elem)
         elif isinstance(elem, Concat):
             return self.render_concat(c, elem)
-        elif isinstance(elem, TestRegex):
-            return self.render_testregex(c, elem)
         elif isinstance(elem, Func):
             return self.render_func(c, elem)
         elif isinstance(elem, WhenThen):
@@ -372,13 +370,6 @@ def render_concat(self, c: Compiler, elem: Concat) -> str:
     def render_alias(self, c: Compiler, elem: Alias) -> str:
         return f"{self.compile(c, elem.expr)} AS {self.quote(elem.name)}"
 
-    def render_testregex(self, c: Compiler, elem: TestRegex) -> str:
-        # TODO: move this method to that mixin! raise here instead, unconditionally.
-        if not isinstance(self, AbstractMixin_Regex):
-            raise NotImplementedError(f"No regex implementation for database '{c.dialect}'")
-        regex = self.test_regex(elem.string, elem.pattern)
-        return self.compile(c, regex)
-
     def render_count(self, c: Compiler, elem: Count) -> str:
         expr = self.compile(c, elem.expr) if elem.expr else "*"
         if elem.distinct:

data_diff/databases/duckdb.py

@@ -20,7 +20,6 @@
     AbstractMixin_MD5,
     AbstractMixin_NormalizeValue,
     AbstractMixin_RandomSample,
-    AbstractMixin_Regex,
 )
 from data_diff.databases.base import (
     Database,
@@ -70,11 +69,6 @@ def random_sample_ratio_approx(self, tbl: AbstractTable, ratio: float) -> Abstra
         return code("SELECT * FROM ({tbl}) USING SAMPLE {percent}%;", tbl=tbl, percent=int(100 * ratio))
 
 
-class Mixin_Regex(AbstractMixin_Regex):
-    def test_regex(self, string: Compilable, pattern: Compilable) -> Compilable:
-        return Func("regexp_matches", [string, pattern])
-
-
 class Dialect(BaseDialect, Mixin_Schema, Mixin_MD5, Mixin_NormalizeValue, AbstractMixin_MD5, AbstractMixin_NormalizeValue):
     name = "DuckDB"
     ROUNDS_ON_PREC_LOSS = False

data_diff/databases/mysql.py

@@ -14,7 +14,6 @@
 from data_diff.abcs.mixins import (
     AbstractMixin_MD5,
     AbstractMixin_NormalizeValue,
-    AbstractMixin_Regex,
 )
 from data_diff.databases.base import (
     Mixin_OptimizerHints,
@@ -61,11 +60,6 @@ def normalize_uuid(self, value: str, coltype: ColType_UUID) -> str:
         return f"TRIM(CAST({value} AS char))"
 
 
-class Mixin_Regex(AbstractMixin_Regex):
-    def test_regex(self, string: Compilable, pattern: Compilable) -> Compilable:
-        return BinBoolOp("REGEXP", [string, pattern])
-
-
 class Dialect(BaseDialect, Mixin_Schema, Mixin_OptimizerHints, Mixin_MD5, Mixin_NormalizeValue, AbstractMixin_MD5, AbstractMixin_NormalizeValue):
     name = "MySQL"
     ROUNDS_ON_PREC_LOSS = True

data_diff/queries/ast_classes.py

@@ -218,9 +218,6 @@ def is_distinct_from(self, other):
     def like(self, other):
         return BinBoolOp("LIKE", [self, other])
 
-    def test_regex(self, other):
-        return TestRegex(self, other)
-
     def sum(self):
         return Func("SUM", [self])
 
@@ -231,12 +228,6 @@ def min(self):
         return Func("MIN", [self])
 
 
-@dataclass
-class TestRegex(ExprNode, LazyOps):
-    string: Expr
-    pattern: Expr
-
-
 @dataclass(eq=False)
 class Func(ExprNode, LazyOps):
     name: str