Fix the aftermath of refactoring: moving of parse_table_name() to dialects

Author: Sergey Vasilyev

tests/common.py

@@ -149,8 +149,8 @@ def setUp(self):
         self.table_src_name = f"src{table_suffix}"
         self.table_dst_name = f"dst{table_suffix}"
 
-        self.table_src_path = self.connection.parse_table_name(self.table_src_name)
-        self.table_dst_path = self.connection.parse_table_name(self.table_dst_name)
+        self.table_src_path = self.connection.dialect.parse_table_name(self.table_src_name)
+        self.table_dst_path = self.connection.dialect.parse_table_name(self.table_dst_name)
 
         drop_table(self.connection, self.table_src_path)
         drop_table(self.connection, self.table_dst_path)

tests/test_database.py

@@ -71,7 +71,7 @@ class TestSchema(unittest.TestCase):
     def test_table_list(self):
         name = "tbl_" + random_table_suffix()
         db = get_conn(self.db_cls)
-        tbl = table(db.parse_table_name(name), schema={"id": int})
+        tbl = table(db.dialect.parse_table_name(name), schema={"id": int})
         q = db.dialect.list_tables(db.default_schema, name)
         assert not db.query(q)
 
@@ -85,7 +85,7 @@ def test_type_mapping(self):
         name = "tbl_" + random_table_suffix()
         db = get_conn(self.db_cls)
         tbl = table(
-            db.parse_table_name(name),
+            db.dialect.parse_table_name(name),
             schema={
                 "int": int,
                 "float": float,

tests/test_database_types.py

@@ -689,8 +689,8 @@ def test_types(self, source_db, target_db, source_type, target_type, type_catego
         src_table_name = f"src_{self._testMethodName[11:]}{table_suffix}"
         dst_table_name = f"dst_{self._testMethodName[11:]}{table_suffix}"
 
-        self.src_table_path = src_table_path = src_conn.parse_table_name(src_table_name)
-        self.dst_table_path = dst_table_path = dst_conn.parse_table_name(dst_table_name)
+        self.src_table_path = src_table_path = src_conn.dialect.parse_table_name(src_table_name)
+        self.dst_table_path = dst_table_path = dst_conn.dialect.parse_table_name(dst_table_name)
 
         start = time.monotonic()
         if not BENCHMARK:

tests/test_joindiff.py

@@ -113,7 +113,7 @@ def test_diff_small_tables(self):
         # self.assertEqual(1, self.differ.stats["table2_min_id"])
 
         # Test materialize
-        materialize_path = self.connection.parse_table_name(f"test_mat_{random_table_suffix()}")
+        materialize_path = self.connection.dialect.parse_table_name(f"test_mat_{random_table_suffix()}")
         mdiffer = self.differ.replace(materialize_to_table=materialize_path)
         diff = list(mdiffer.diff_tables(self.table, self.table2))
         self.assertEqual(expected, diff)