Revert "Bump thrift to 0.23.0 (#796)" — fixes install failure on DBR LTS (ES-1960554)#840
Merged
Merged
Conversation
This reverts commit 9535255. Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
vikrantpuppala
force-pushed
the
revert-thrift-0.23.0-es1960554
branch
from
c0bcbae to
6e225c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #796 ("Bump thrift to 0.23.0"), restoring the thrift pin to
~=0.22.0(>=0.22.0,<0.23.0) andpoetry.lockto thrift 0.22.0.This is an exact
git revertof commit 9535255.Why
databricks-sql-connector4.2.7 widened the thrift pin to>=0.22.0,<0.24.0, which allowed thrift 0.23.0 to be resolved. thrift ships sdist-only (no wheels), so every install buildssetup.pyfrom source. thrift 0.23.0'ssetup.pycallssys.exit(0)on the build success path, which terminates the PEP 517 in-process build backend before pip writes its expectedoutput.json. On setuptools ≤ 68 (shipped by DBR 14.3 LTS and 15.4 LTS) pip treats this as a hard failure:This caused install/job failures for customers on those runtimes with an unpinned (transitive) dependency on the connector. Tracked as SEV0 ES-1960554; 4.2.7 was yanked from PyPI as the immediate mitigation.
Follow-ups (not in this PR)
sys.exit(0)) has a fix submitted to Apache Thrift: THRIFT-6067 / THRIFT-6067: [py] Remove sys.exit() from setup.py to fix PEP 517 builds on setuptools < 69 apache/thrift#3584.Co-authored-by: Claude Opus 4.8 noreply@anthropic.com