Remove custom config loaders and add acceptance test

Remove the custom Loaders override in resolveConfig. The CLI's
env.NewConfigLoader panics on non-string config attributes (e.g.
DATABRICKS_RATE_LIMIT which is an int), and the SDK's default loaders
already handle env vars properly. This aligns with how cmd/root/auth.go
creates config objects.

Also add an acceptance test under acceptance/cmd/doctor/ that exercises
the full doctor flow with a mock HTTP server.

Co-authored-by: Isaac

Author: simonfaltum

acceptance/cmd/doctor/out.test.toml

@@ -0,0 +1,10 @@
+
+=== Doctor with --profile flag
+
+>>> [CLI] doctor --profile my-workspace --output json
+CLI Version: info - [DEV_VERSION]
+Config File: pass - ~/.databrickscfg (1 profiles)
+Current Profile: info - my-workspace
+Authentication: pass - OK (pat)
+Identity: pass - test@example.com
+Network: pass - [DATABRICKS_URL] is reachable

acceptance/cmd/doctor/output.txt

@@ -0,0 +1,10 @@
+sethome "./home"
+
+cat > "./home/.databrickscfg" <<EOF
+[my-workspace]
+host  = $DATABRICKS_HOST
+token = $DATABRICKS_TOKEN
+EOF
+
+title "Doctor with --profile flag\n"
+trace $CLI doctor --profile my-workspace --output json | jq -r '.[] | "\(.name): \(.status) - \(.message)"'

acceptance/cmd/doctor/script

@@ -0,0 +1,18 @@
+Local = true
+Cloud = false
+
+Ignore = [
+    "home"
+]
+
+[[Server]]
+Pattern = "GET /api/2.0/preview/scim/v2/Me"
+Response.Body = '''
+{
+  "userName": "test@example.com"
+}
+'''
+
+[[Server]]
+Pattern = "HEAD /"
+Response.Body = ''

acceptance/cmd/doctor/test.toml

@@ -149,12 +149,6 @@ func resolveConfig(cmd *cobra.Command) (*config.Config, error) {
 		cfg.ConfigFile = configFile
 	}
 
-	cfg.Loaders = []config.Loader{
-		env.NewConfigLoader(ctx),
-		config.ConfigAttributes,
-		config.ConfigFile,
-	}
-
 	profileFlag := cmd.Flag("profile")
 	if profileFlag != nil && profileFlag.Changed {
 		cfg.Profile = profileFlag.Value.String()

cmd/doctor/checks.go

@@ -281,20 +281,18 @@ func TestCheckAuthAccountLevel(t *testing.T) {
 	assert.NotNil(t, authCfg)
 }
 
-func TestResolveConfigUsesCommandContextEnv(t *testing.T) {
+func TestResolveConfigUsesEnvVars(t *testing.T) {
 	clearConfigEnv(t)
-	t.Setenv("DATABRICKS_HOST", "https://real.example.com")
-	t.Setenv("DATABRICKS_TOKEN", "real-token")
+	t.Setenv("DATABRICKS_HOST", "https://env.example.com")
+	t.Setenv("DATABRICKS_TOKEN", "env-token")
 
 	ctx := cmdio.MockDiscard(t.Context())
-	ctx = env.Set(ctx, "DATABRICKS_HOST", "https://context.example.com")
-	ctx = env.Set(ctx, "DATABRICKS_TOKEN", "context-token")
 	cmd := newTestCmd(ctx)
 
 	cfg, err := resolveConfig(cmd)
 	require.NoError(t, err)
-	assert.Equal(t, "https://context.example.com", cfg.Host)
-	assert.Equal(t, "context-token", cfg.Token)
+	assert.Equal(t, "https://env.example.com", cfg.Host)
+	assert.Equal(t, "env-token", cfg.Token)
 }
 
 func TestCheckIdentitySuccess(t *testing.T) {
@@ -512,9 +510,10 @@ func TestCheckNetworkConfigResolutionFailureNoHost(t *testing.T) {
 	err := os.WriteFile(configFile, []byte("[DEFAULT]\nhost = https://example.com\n"), 0o600)
 	require.NoError(t, err)
 
+	t.Setenv("DATABRICKS_CONFIG_FILE", configFile)
+	t.Setenv("DATABRICKS_CONFIG_PROFILE", "missing")
+
 	ctx := cmdio.MockDiscard(t.Context())
-	ctx = env.Set(ctx, "DATABRICKS_CONFIG_FILE", configFile)
-	ctx = env.Set(ctx, "DATABRICKS_CONFIG_PROFILE", "missing")
 	cmd := newTestCmd(ctx)
 
 	cfg, resolveErr := resolveConfig(cmd)