Fix review issues: unified-host, HTTP method, config path, skip status

- isAccountLevelConfig now handles both AccountHost and UnifiedHost
- checkIdentity uses isAccountLevelConfig instead of raw HostType check
- Use http.MethodGet and authCfg.Host instead of empty strings
- Remove hardcoded config file path (let SDK resolve it)
- Add "skip" to CheckResult status doc comment
- checkCurrentProfile shows resolved profile from config file

Co-authored-by: Isaac

Author: simonfaltum

cmd/doctor/checks.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"path/filepath"
 	"time"
 
 	"github.com/databricks/cli/internal/build"
@@ -38,7 +37,7 @@ func runChecks(cmd *cobra.Command) []CheckResult {
 
 	results = append(results, checkCLIVersion())
 	results = append(results, checkConfigFile(cmd))
-	results = append(results, checkCurrentProfile(cmd))
+	results = append(results, checkCurrentProfile(cmd, cfg))
 
 	authResult, authCfg := checkAuth(cmd, cfg, err)
 	results = append(results, authResult)
@@ -105,7 +104,7 @@ func checkConfigFile(cmd *cobra.Command) CheckResult {
 	}
 }
 
-func checkCurrentProfile(cmd *cobra.Command) CheckResult {
+func checkCurrentProfile(cmd *cobra.Command, resolvedCfg *config.Config) CheckResult {
 	ctx := cmd.Context()
 
 	profileFlag := cmd.Flag("profile")
@@ -125,6 +124,15 @@ func checkCurrentProfile(cmd *cobra.Command) CheckResult {
 		}
 	}
 
+	// Check if the SDK resolved a profile (e.g. DEFAULT section in .databrickscfg).
+	if resolvedCfg != nil && resolvedCfg.Profile != "" {
+		return CheckResult{
+			Name:    "Current Profile",
+			Status:  statusInfo,
+			Message: resolvedCfg.Profile + " (resolved from config file)",
+		}
+	}
+
 	return CheckResult{
 		Name:    "Current Profile",
 		Status:  statusInfo,
@@ -138,8 +146,6 @@ func resolveConfig(cmd *cobra.Command) (*config.Config, error) {
 
 	if configFile := env.Get(ctx, "DATABRICKS_CONFIG_FILE"); configFile != "" {
 		cfg.ConfigFile = configFile
-	} else if home := env.Get(ctx, env.HomeEnvVar()); home != "" {
-		cfg.ConfigFile = filepath.Join(home, ".databrickscfg")
 	}
 
 	cfg.Loaders = []config.Loader{
@@ -158,7 +164,17 @@ func resolveConfig(cmd *cobra.Command) (*config.Config, error) {
 
 // isAccountLevelConfig returns true if the resolved config targets account-level APIs.
 func isAccountLevelConfig(cfg *config.Config) bool {
-	return cfg.AccountID != "" && cfg.Host != "" && cfg.HostType() == config.AccountHost
+	if cfg.AccountID == "" || cfg.Host == "" {
+		return false
+	}
+	switch cfg.HostType() {
+	case config.AccountHost:
+		return true
+	case config.UnifiedHost:
+		return true
+	default:
+		return false
+	}
 }
 
 // checkAuth uses the resolved config to authenticate.
@@ -203,7 +219,7 @@ func checkAuth(cmd *cobra.Command, cfg *config.Config, resolveErr error) (CheckR
 		authCfg = w.Config
 	}
 
-	req, err := http.NewRequestWithContext(ctx, "", "", nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, authCfg.Host, nil)
 	if err != nil {
 		return CheckResult{
 			Name:    "Authentication",
@@ -240,7 +256,7 @@ func checkIdentity(cmd *cobra.Command, authCfg *config.Config) CheckResult {
 	defer cancel()
 
 	// Account-level configs don't support the /me endpoint for workspace identity.
-	if authCfg.HostType() == config.AccountHost {
+	if isAccountLevelConfig(authCfg) {
 		return CheckResult{
 			Name:    "Identity",
 			Status:  statusSkip,

cmd/doctor/doctor.go

@@ -15,7 +15,7 @@ import (
 // CheckResult holds the outcome of a single diagnostic check.
 type CheckResult struct {
 	Name    string `json:"name"`
-	Status  string `json:"status"` // "pass", "fail", "warn", "info"
+	Status  string `json:"status"` // "pass", "fail", "warn", "info", "skip"
 	Message string `json:"message"`
 	Detail  string `json:"detail,omitempty"`
 }

cmd/doctor/doctor_test.go

@@ -143,7 +143,7 @@ func TestCheckCurrentProfileDefault(t *testing.T) {
 	ctx := cmdio.MockDiscard(t.Context())
 	cmd := newTestCmd(ctx)
 
-	result := checkCurrentProfile(cmd)
+	result := checkCurrentProfile(cmd, nil)
 	assert.Equal(t, "Current Profile", result.Name)
 	assert.Equal(t, statusInfo, result.Status)
 	assert.Equal(t, "none (using environment or defaults)", result.Message)
@@ -156,7 +156,7 @@ func TestCheckCurrentProfileFromFlag(t *testing.T) {
 	require.NoError(t, err)
 	cmd.Flag("profile").Changed = true
 
-	result := checkCurrentProfile(cmd)
+	result := checkCurrentProfile(cmd, nil)
 	assert.Equal(t, "Current Profile", result.Name)
 	assert.Equal(t, statusInfo, result.Status)
 	assert.Equal(t, "staging", result.Message)
@@ -167,7 +167,7 @@ func TestCheckCurrentProfileFromEnv(t *testing.T) {
 	ctx = env.Set(ctx, "DATABRICKS_CONFIG_PROFILE", "from-env")
 	cmd := newTestCmd(ctx)
 
-	result := checkCurrentProfile(cmd)
+	result := checkCurrentProfile(cmd, nil)
 	assert.Equal(t, statusInfo, result.Status)
 	assert.Equal(t, "from-env (from DATABRICKS_CONFIG_PROFILE)", result.Message)
 }
@@ -180,7 +180,7 @@ func TestCheckCurrentProfileFlagOverridesEnv(t *testing.T) {
 	require.NoError(t, err)
 	cmd.Flag("profile").Changed = true
 
-	result := checkCurrentProfile(cmd)
+	result := checkCurrentProfile(cmd, nil)
 	assert.Equal(t, "from-flag", result.Message)
 }