Skip to content

Storage connections may leak on Caddy reload #722

Description

@everyx

When Caddy reloads (configuration change), old storage connections are not properly closed, leading to resource leaks. Each reload creates new storage instances while old ones remain open.

In souin/plugins/caddy/app.go:

func (s SouinApp) Start() error {
    core.ResetRegisteredStorages()  // Only clears the map
    _, _ = up.Delete(stored_providers_key)
    _, _ = up.LoadOrStore(stored_providers_key, newStorageProvider())
    return nil
}

The Start() method is called on every Caddy configuration reload. While ResetRegisteredStorages() clears the registered storage map, the actual storage connections (e.g., Badger DB) are never closed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions