update java and JuniTest + JMemoryBuddy

Author: danielpeintner

.github/workflows/gradle.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        java: [ '16' ]
+        java: [ '17-ea' ] // 16
       fail-fast: false
     name: ${{ matrix.os }}
     steps:

build.gradle

@@ -31,17 +31,19 @@ dependencies {
     implementation 'org.xmlunit:xmlunit-core:2.8.1'
     implementation 'jakarta.xml.bind:jakarta.xml.bind-api:2.3.3'
     implementation 'org.glassfish.jaxb:jaxb-runtime:2.3.3'
+    implementation 'org.junit.jupiter:junit-jupiter:5.7.0'
 
     // test dependencies
-    testImplementation group: 'junit', name: 'junit', version: '4.13'
+    testImplementation("org.junit.jupiter:junit-jupiter:5.7.2")
+    testImplementation 'de.sandec:JMemoryBuddy:0.5.1'
 }
 
 repositories {
     mavenCentral()
 }
 
 javafx {
-    version = '16' // '14.0.2.1'
+    version = '17-ea+16' // '16' // '14.0.2.1'
     modules = ['javafx.controls']
 }
 
@@ -78,15 +80,15 @@ runtime {
         installerName = applicationName
         // Set the environment property BADASS_JLINK_JPACKAGE_HOME or explicitly configure the below property
         def os = org.gradle.internal.os.OperatingSystem.current()
-        if(os.macOsX) {
+        /* if(os.macOsX) {
             // jpackageHome = '/Library/Java/JavaVirtualMachines/adoptopenjdk-16.jdk/Contents/Home'
             jpackageHome = '/Library/Java/JavaVirtualMachines/jdk-17-b-32.jdk/Contents/Home'
         } else if(os.windows) {
             jpackageHome = 'C:/Program Files/Java/jdk-16+36'
         } else {
             // Linux
             jpackageHome = '/usr/lib/jvm/jdk-16'
-        }
+        } */
         jvmArgs = []
         installerOptions = [
                 // '--file-associations', 'src/main/resources/associations.properties',
@@ -97,7 +99,7 @@ runtime {
         if(os.macOsX) {
             imageOptions = ['--icon', 'src/main/deploy/package/macosx/hello.icns']
             installerOptions += [
-                '--mac-sign',
+                // '--mac-sign',
                 // '--mac-signing-key-user-name', System.getenv('SIGNING_KEY_USER_NAME'),
                 // '--mac-signing-keychain', System.getenv('SIGNING_KEYCHAIN_PATH')
             ]

src/test/java/com/example/hellofx/HelloFXTest.java

@@ -1,8 +1,8 @@
 package com.example.hellofx;
 
-import static org.junit.Assert.*;
+import org.junit.jupiter.api.Test;
 
-import org.junit.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class HelloFXTest {
 

src/test/java/com/example/hellofx/LeakTest.java

@@ -0,0 +1,68 @@
+package com.example.hellofx;
+
+import de.sandec.jmemorybuddy.JMemoryBuddy;
+import javafx.application.Platform;
+import javafx.scene.Scene;
+import javafx.scene.control.Button;
+import javafx.scene.control.MenuButton;
+import javafx.scene.control.ToolBar;
+import javafx.scene.layout.BorderPane;
+import javafx.stage.Stage;
+import org.junit.jupiter.api.Test;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+
+public class LeakTest {
+
+    @Test
+    public void stageLeakWithMenuButton() throws Exception {
+        JMemoryBuddy.memoryTest((checker) -> {
+            CountDownLatch startupLatch = new CountDownLatch(1);
+            CountDownLatch showingLatch = new CountDownLatch(1);
+            AtomicReference<Stage> stage = new AtomicReference<>();
+
+            Platform.startup(() -> {
+                startupLatch.countDown();
+            });
+            try {
+                startupLatch.await(15, TimeUnit.SECONDS);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
+
+            Platform.runLater(() -> {
+                stage.set(new Stage());
+                BorderPane root = new BorderPane();
+
+                ToolBar tb = new ToolBar();
+                root.setTop(tb);
+                tb.getItems().add(new Button("A"));
+                tb.getItems().add(new Button("B"));
+                tb.getItems().add(new Button("C"));
+                // causes memory leak !!!
+                tb.getItems().add(new MenuButton("MB"));
+
+                stage.get().setScene(new Scene(root));
+                stage.get().setOnShown(l -> {
+                    Platform.runLater(() -> showingLatch.countDown());
+                });
+                stage.get().show();
+            });
+
+            try {
+                showingLatch.await(15, TimeUnit.SECONDS);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
+
+            Platform.runLater(() -> {
+                stage.get().close();
+            });
+
+            checker.assertCollectable(stage.get());
+        });
+    }
+
+}