Commit 94fc518
committed
use rem instead of em for examples
Not safe to use em since if you don't have any explicit font-size defined, it just do nothing.
Here was a example where using em didn't work
```html
<style>
@import "../node_modules/cssrecipes-custom-media-queries/index.css";
@import "../node_modules/cssrecipes-grid/index.css";
@import "../node_modules/cssrecipes-utils/lib/all.css";
@import "../node_modules/cssrecipes-utils/lib/max.css";
.r-Grid {
width: 50em;
}
</style>
<body>
<div class="r-Grid">
<h1 class="r-Grid-cell">
Hi there
</h1>
</div>
```
.r-Grid have width == 0 :( (confirmed on firefox & chrome)1 parent 146c0c8 commit 94fc518
1 file changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| |||
0 commit comments