I would like to open a PR

[GabijaBern]

Hello,

I would like to open a PR, what is your preferred way of doing that?

[thomas-lowe]

Hi Gabi,
you are welcome to create a pull request. Just push to a branch and use this site to create a pull request to the main.

If the changes are big, like a whole new command, it would be better to talk through them first.

[GabijaBern]

thank you, could you check if I have permissions to push? I get 403 error...

[tim-devereux]

Hi @GabijaBern

Github no longer allows pushing code using https, that could be the issue? Maybe try authenticate using ssh.

https://docs.github.com/en/authentication/connecting-to-github-with-ssh

[thomas-lowe]

[like] Lowe, Tom (Data61, Pullenvale) reacted to your message:

…

________________________________ From: Tim Devereux ***@***.***> Sent: Wednesday, November 6, 2024 2:40:56 AM To: csiro-robotics/raycloudtools ***@***.***> Cc: Lowe, Tom (Data61, Pullenvale) ***@***.***>; Comment ***@***.***> Subject: Re: [csiro-robotics/raycloudtools] I would like to open a PR (Discussion #21) Hi @GabijaBern<https://github.com/GabijaBern> Github no longer allows pushing code using https, that could be the issue? Maybe try authenticate using ssh. — Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKSVQ4EBUEI7LW7GRTIY5ETZ7F6TRAVCNFSM6AAAAABREB7G4WVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMJWGE3DCMI>. You are receiving this because you commented.Message ID: ***@***.***>

[GabijaBern]

Hey, thanks for the suggestion, but I am using ssh. Could you check in the settings if writing is restricted?

[thomas-lowe]

Sorry Gabi, I am not sure what this is. Have checked the settings and it is public and pushes are permitted. Can't see anything preventing pull requests and others have done it before.
Very recently two-factor authentication was added, so that might be a culprit.
I wonder how else we can get a pull request in. I'm all day meetings today and tomorrow hence the slow reply. Needs more thought to figure out.

[tim-devereux]

Hi @GabijaBern I can't see a fork listed under your account. I think you'll need to create your own fork, make the changes then push to the upstream repository.

[GabijaBern]

Ah, thanks Tim, but why is it the preferred way of developing? I will try that : )

[GabijaBern]

Actually, maybe I am more used to private repos with all permissions, happy to do the fork.

[tim-devereux]

No worries. Basically, if you were to try push without making a fork, you'd have to be added as a collaborator first to authenticate.

[thomas-lowe]

[like] Lowe, Tom (Data61, Pullenvale) reacted to your message:

…

________________________________ From: Tim Devereux ***@***.***> Sent: Wednesday, November 6, 2024 12:23:22 PM To: csiro-robotics/raycloudtools ***@***.***> Cc: Lowe, Tom (Data61, Pullenvale) ***@***.***>; Comment ***@***.***> Subject: Re: [csiro-robotics/raycloudtools] I would like to open a PR (Discussion #21) No worries. Basically, if you were to try push without making a fork, you'd have to be added as a collaborator first to authenticate. — Reply to this email directly, view it on GitHub<#21 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKSVQ4GYJLYBBWLTT6C2YOTZ7IC3VAVCNFSM6AAAAABREB7G4WVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMJWGYZDAMI>. You are receiving this because you commented.Message ID: ***@***.***>