Skip to content

Commit b384450

Browse files
committed
Merge branch 'release/1.4.0'
2 parents 1af1186 + 71a6a9f commit b384450

11 files changed

Lines changed: 23 additions & 41 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/setup-java@v4
1313
with:
1414
distribution: 'temurin'
15-
java-version: 17
15+
java-version: 24
1616
cache: 'maven'
1717
- name: Ensure to use tagged version
1818
if: startsWith(github.ref, 'refs/tags/')

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- uses: actions/setup-java@v4
2323
with:
2424
distribution: 'temurin'
25-
java-version: 17
25+
java-version: 24
2626
cache: 'maven'
2727
- name: Initialize CodeQL
2828
uses: github/codeql-action/init@v3

.github/workflows/dependency-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
with:
1515
runner-os: 'macos-latest'
1616
java-distribution: 'temurin'
17-
java-version: 21
17+
java-version: 24
1818
secrets:
1919
nvd-api-key: ${{ secrets.NVD_API_KEY }}
2020
slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_URL }}

.github/workflows/publish-central.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/setup-java@v4
1212
with:
1313
distribution: 'temurin'
14-
java-version: 17
14+
java-version: 24
1515
cache: 'maven'
1616
server-id: central
1717
server-username: MAVEN_CENTRAL_USERNAME

.github/workflows/publish-github.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/setup-java@v4
1212
with:
1313
distribution: 'temurin'
14-
java-version: 17
14+
java-version: 24
1515
cache: 'maven'
1616
- name: Enforce project version ${{ github.event.release.tag_name }}
1717
run: mvn versions:set -B -DnewVersion=${{ github.event.release.tag_name }}

.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ macOS-specific implementations of [integrations-api](https://github.com/cryptoma
66

77
Since this project involves JNI, you need Java as well as Xcode build tools:
88

9-
* JDK 17
9+
* JDK 24
1010
* Maven
1111
* XCode Command Line Tools (run `xcode-select --install`)

pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<modelVersion>4.0.0</modelVersion>
66
<groupId>org.cryptomator</groupId>
77
<artifactId>integrations-mac</artifactId>
8-
<version>1.3.2</version>
8+
<version>1.4.0</version>
99

1010
<name>Cryptomator Integrations for macOS</name>
1111
<description>Provides optional macOS services used by Cryptomator</description>
@@ -29,18 +29,18 @@
2929

3030
<properties>
3131
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
32-
<project.jdk.version>17</project.jdk.version>
32+
<project.jdk.version>24</project.jdk.version>
3333

3434
<!-- runtime dependencies -->
35-
<api.version>1.5.1</api.version>
35+
<api.version>1.6.0</api.version>
3636
<slf4j.version>2.0.17</slf4j.version>
3737

3838
<!-- test dependencies -->
39-
<junit.jupiter.version>5.12.1</junit.jupiter.version>
40-
<mockito.version>5.16.1</mockito.version>
39+
<junit.jupiter.version>5.12.2</junit.jupiter.version>
40+
<mockito.version>5.17.0</mockito.version>
4141

4242
<!-- build plugin dependencies -->
43-
<dependency-check.version>12.1.0</dependency-check.version>
43+
<dependency-check.version>12.1.1</dependency-check.version>
4444
<central-publishing.version>0.7.0</central-publishing.version>
4545
</properties>
4646

src/main/java/org/cryptomator/macos/keychain/MacSystemKeychainAccess.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package org.cryptomator.macos.keychain;
22

3+
import org.cryptomator.integrations.common.LocalizedDisplayName;
34
import org.cryptomator.integrations.common.OperatingSystem;
45
import org.cryptomator.integrations.common.Priority;
56
import org.cryptomator.integrations.keychain.KeychainAccessException;
67
import org.cryptomator.integrations.keychain.KeychainAccessProvider;
7-
import org.cryptomator.macos.common.Localization;
88

99
/**
1010
* Stores passwords in the macOS system keychain.
@@ -14,6 +14,7 @@
1414
*/
1515
@Priority(1000)
1616
@OperatingSystem(OperatingSystem.Value.MAC)
17+
@LocalizedDisplayName(bundle = "MacIntegrationsBundle", key = "org.cryptomator.macos.keychain.displayName")
1718
public class MacSystemKeychainAccess implements KeychainAccessProvider {
1819

1920
private static final String SERVICE_NAME = System.getProperty("cryptomator.integrationsMac.keychainServiceName", "Cryptomator");
@@ -29,21 +30,11 @@ public MacSystemKeychainAccess() {
2930
this.keychain = keychain;
3031
}
3132

32-
@Override
33-
public String displayName() {
34-
return Localization.get().getString("org.cryptomator.macos.keychain.displayName");
35-
}
36-
3733
@Override
3834
public void storePassphrase(String key, String displayName, CharSequence passphrase) throws KeychainAccessException {
3935
keychain.storePassword(SERVICE_NAME, key, passphrase, false);
4036
}
4137

42-
@Override
43-
public void storePassphrase(String key, String displayName, CharSequence passphrase, boolean requireOsAuthentication) throws KeychainAccessException {
44-
keychain.storePassword(SERVICE_NAME, key, passphrase, requireOsAuthentication);
45-
}
46-
4738
@Override
4839
public char[] loadPassphrase(String key) {
4940
return keychain.loadPassword(SERVICE_NAME, key);

src/main/java/org/cryptomator/macos/keychain/TouchIdKeychainAccess.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package org.cryptomator.macos.keychain;
22

3+
import org.cryptomator.integrations.common.LocalizedDisplayName;
34
import org.cryptomator.integrations.common.OperatingSystem;
45
import org.cryptomator.integrations.common.Priority;
56
import org.cryptomator.integrations.keychain.KeychainAccessException;
67
import org.cryptomator.integrations.keychain.KeychainAccessProvider;
7-
import org.cryptomator.macos.common.Localization;
88

99
/**
1010
* Stores passwords in the macOS system keychain. Requires an authenticated user to do so.
@@ -15,6 +15,7 @@
1515
*/
1616
@Priority(1010)
1717
@OperatingSystem(OperatingSystem.Value.MAC)
18+
@LocalizedDisplayName(bundle = "MacIntegrationsBundle", key = "org.cryptomator.macos.keychain.touchIdDisplayName")
1819
public class TouchIdKeychainAccess implements KeychainAccessProvider {
1920

2021
private static final String SERVICE_NAME = System.getProperty("cryptomator.integrationsMac.keychainServiceName", "Cryptomator");
@@ -30,21 +31,11 @@ public TouchIdKeychainAccess() {
3031
this.keychain = keychain;
3132
}
3233

33-
@Override
34-
public String displayName() {
35-
return Localization.get().getString("org.cryptomator.macos.keychain.touchIdDisplayName");
36-
}
37-
3834
@Override
3935
public void storePassphrase(String key, String displayName, CharSequence passphrase) throws KeychainAccessException {
4036
keychain.storePassword(SERVICE_NAME, key, passphrase, true);
4137
}
4238

43-
@Override
44-
public void storePassphrase(String key, String displayName, CharSequence passphrase, boolean requireOsAuthentication) throws KeychainAccessException {
45-
keychain.storePassword(SERVICE_NAME, key, passphrase, requireOsAuthentication);
46-
}
47-
4839
@Override
4940
public char[] loadPassphrase(String key) {
5041
return keychain.loadPassword(SERVICE_NAME, key);

0 commit comments

Comments
 (0)