apply suggestions from code review

Author: overheadhunter

src/main/java/org/cryptomator/integrations/update/DownloadUpdateMechanism.java

@@ -22,7 +22,7 @@
 
 public abstract class DownloadUpdateMechanism implements UpdateMechanism<DownloadUpdateInfo> {
 
-	private static final Logger LOG = LoggerFactory .getLogger(DownloadUpdateMechanism.class);
+	private static final Logger LOG = LoggerFactory.getLogger(DownloadUpdateMechanism.class);
 	private static final String LATEST_VERSION_API_URL = "https://api.cryptomator.org/connect/apps/desktop/latest-version?format=1";
 	private static final ObjectMapper MAPPER = new ObjectMapper();
 
@@ -32,7 +32,8 @@ public DownloadUpdateInfo checkForUpdate(String currentVersion, HttpClient httpC
 			HttpRequest request = HttpRequest.newBuilder().uri(URI.create(LATEST_VERSION_API_URL)).build();
 			HttpResponse<InputStream> response = httpClient.send(request, HttpResponse.BodyHandlers.ofInputStream());
 			if (response.statusCode() != 200) {
-				throw new RuntimeException("Failed to fetch release: " + response.statusCode());
+				LOG.warn("Failed to fetch release: HTTP {}", response.statusCode());
+				return null;
 			}
 			var release = MAPPER.readValue(response.body(), LatestVersionResponse.class);
 			return checkForUpdate(currentVersion, release);
@@ -94,7 +95,7 @@ public record LatestVersion(
 	@JsonIgnoreProperties(ignoreUnknown = true)
 	public record Asset(
 			@JsonProperty("name") String name,
-			@JsonProperty("digest") String digest, // TODO: verify this starts with "sha256:"?
+			@JsonProperty("digest") String digest,
 			@JsonProperty("size") long size,
 			@JsonProperty("downloadUrl") String downloadUrl
 	) {}
@@ -106,7 +107,9 @@ private class FirstStep extends DownloadUpdateStep {
 		public FirstStep(Path workDir, DownloadUpdateInfo updateInfo) {
 			var uri = URI.create(updateInfo.asset().downloadUrl);
 			var destination = workDir.resolve(updateInfo.asset().name);
-			var digest = HexFormat.of().withLowerCase().parseHex(updateInfo.asset().digest.substring(7)); // remove "sha256:" prefix
+			var digest = updateInfo.asset().digest().startsWith("sha256:")
+					? HexFormat.of().withLowerCase().parseHex(updateInfo.asset().digest.substring(7)) // remove "sha256:" prefix
+					: null;
 			var size = updateInfo.asset().size;
 			super(uri, destination, digest, size);
 			this.workDir = workDir;

src/main/java/org/cryptomator/integrations/update/DownloadUpdateStep.java

@@ -1,6 +1,7 @@
 package org.cryptomator.integrations.update;
 
 import org.cryptomator.integrations.Localization;
+import org.jetbrains.annotations.Nullable;
 
 import java.io.FilterInputStream;
 import java.io.IOException;
@@ -16,6 +17,7 @@
 import java.nio.file.StandardOpenOption;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
+import java.time.Duration;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
@@ -35,11 +37,11 @@ public abstract class DownloadUpdateStep implements UpdateStep {
 	/**
 	 * Creates a new DownloadUpdateProcess instance.
 	 * @param source The URI from which the update will be downloaded.
-	 * @param destination The path to theworking directory where the downloaded file will be saved.
+	 * @param destination The path where to save the downloaded file.
 	 * @param checksum (optional) The expected SHA-256 checksum of the downloaded file, can be null if not required.
 	 * @param estDownloadSize The estimated size of the download in bytes.
 	 */
-	protected DownloadUpdateStep(URI source, Path destination, byte[] checksum, long estDownloadSize) {
+	protected DownloadUpdateStep(URI source, Path destination, @Nullable byte[] checksum, long estDownloadSize) {
 		this.source = source;
 		this.destination = destination;
 		this.checksum = checksum;
@@ -88,7 +90,7 @@ public void cancel() {
 
 	protected void download() {
 		var request = HttpRequest.newBuilder().uri(source).GET().build();
-		try (HttpClient client = HttpClient.newBuilder().followRedirects(HttpClient.Redirect.ALWAYS).build()) {
+		try (HttpClient client = HttpClient.newBuilder().followRedirects(HttpClient.Redirect.ALWAYS).connectTimeout(Duration.ofSeconds(10)).build()) {
 			downloadInternal(client, request);
 		} catch (IOException e) {
 			downloadException = e;

src/main/java/org/cryptomator/integrations/update/UpdateStep.java

@@ -67,7 +67,7 @@ public String description() {
 	void cancel();
 
 	/**
-	 * Blocks the current thread until this update step completed or an error occured.
+	 * Blocks the current thread until this update step completed or an error occurred.
 	 * <p>
 	 * If the step is already complete, this method returns immediately.
 	 *
@@ -76,7 +76,7 @@ public String description() {
 	void await() throws InterruptedException;
 
 	/**
-	 * Blocks the current thread until this update step completed or an error occured, or until the specified timeout expires.
+	 * Blocks the current thread until this update step completed or an error occurred, or until the specified timeout expires.
 	 * <p>
 	 * If the step is already complete, this method returns immediately.
 	 *