implement more suggestions from code review

[deploy]

Author: overheadhunter

src/main/java/org/cryptomator/integrations/update/DownloadUpdateStep.java

@@ -13,6 +13,7 @@
 import java.net.http.HttpResponse;
 import java.nio.channels.Channels;
 import java.nio.channels.FileChannel;
+import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.StandardOpenOption;
 import java.security.MessageDigest;
@@ -54,7 +55,14 @@ public String description() {
 		return switch (downloadThread.getState()) {
 			case NEW -> Localization.get().getString("org.cryptomator.api.update.download.new");
 			case TERMINATED -> Localization.get().getString("org.cryptomator.api.update.download.done");
-			default -> Localization.get().getString("org.cryptomator.api.update.download.progress").formatted(preparationProgress() * 100);
+			default -> {
+				double progress = preparationProgress();
+				if (progress < 0.0) {
+					yield Localization.get().getString("org.cryptomator.api.update.download.indeterminateProgress");
+				} else {
+					yield Localization.get().getString("org.cryptomator.api.update.download.progress").formatted(progress * 100.0);
+				}
+			}
 		};
 	}
 
@@ -86,6 +94,11 @@ public boolean await(long timeout, TimeUnit unit) throws InterruptedException {
 	@Override
 	public void cancel() {
 		downloadThread.interrupt();
+		try {
+			Files.deleteIfExists(destination);
+		} catch (IOException e) {
+			// ignore, this is a best-effort cleanup
+		}
 	}
 
 	protected void download() {
@@ -119,7 +132,7 @@ protected void downloadInternal(HttpClient client, HttpRequest request) throws I
 			// prepare checksum calculation
 			MessageDigest sha256;
 			try {
-				sha256 = MessageDigest.getInstance("SHA-256"); // Initialize SHA-256 digest, not used here but can be extended for checksum validation
+				sha256 = MessageDigest.getInstance("SHA-256");
 			} catch (NoSuchAlgorithmException e) {
 				throw new AssertionError("Every implementation of the Java platform is required to support [...] SHA-256", e);
 			}

src/main/java/org/cryptomator/integrations/update/UpdateStep.java

@@ -68,6 +68,7 @@ public String description() {
 
 	/**
 	 * Blocks the current thread until this update step completed or an error occurred.
+	 * If this step failed, an exception will be rethrown as soon as attempting to invoke {@link #nextStep()}.
 	 * <p>
 	 * If the step is already complete, this method returns immediately.
 	 *
@@ -77,6 +78,7 @@ public String description() {
 
 	/**
 	 * Blocks the current thread until this update step completed or an error occurred, or until the specified timeout expires.
+	 * If this step failed, an exception will be rethrown as soon as attempting to invoke {@link #nextStep()}.
 	 * <p>
 	 * If the step is already complete, this method returns immediately.
 	 *

src/main/resources/IntegrationsApi.properties

@@ -1,4 +1,5 @@
 org.cryptomator.api.update.download.new=Download...
+org.cryptomator.api.update.download.indeterminateProgress=Downloading...
 org.cryptomator.api.update.download.progress=Downloading... %1.0f%%
 org.cryptomator.api.update.download.done=Downloaded.