Skip to content

Commit 279ba84

Browse files
committed
fix a case insensitive bug
1 parent 7e4ab60 commit 279ba84

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

lib/importproject.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -760,9 +760,9 @@ namespace {
760760

761761
// Replace "And" and "Or" with "&&" and "||"
762762
for (Token *tok = tokenlist.front(); tok; tok = tok->next()) {
763-
if (tok->str() == "And")
763+
if (caseInsensitiveStringCompare(tok->str(), "and") == 0)
764764
tok->str("&&");
765-
else if (tok->str() == "Or")
765+
else if (caseInsensitiveStringCompare(tok->str(), "or") == 0)
766766
tok->str("||");
767767
}
768768

test/testimportproject.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -694,6 +694,8 @@ class TestImportProject : public TestFixture {
694694
ASSERT(!cppcheck::testing::evaluateVcxprojCondition("!('$(Configuration)|$(Platform)' == 'Debug|Win32' )", "Debug", "Win32"));
695695
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" '$(Configuration)' == 'Debug' And '$(Platform)' == 'Win32'", "Debug", "Win32"));
696696
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" '$(Configuration)' == 'Debug' Or '$(Platform)' == 'Win32'", "Release", "Win32"));
697+
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" '$(Configuration)' == 'Debug' and '$(Platform)' == 'Win32'", "Debug", "Win32"));
698+
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" '$(Configuration)' == 'Debug' or '$(Platform)' == 'Win32'", "Release", "Win32"));
697699
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" $(Configuration.StartsWith('Debug'))", "Debug-AddressSanitizer", "Win32"));
698700
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" $(Configuration.EndsWith('AddressSanitizer'))", "Debug-AddressSanitizer", "Win32"));
699701
ASSERT(cppcheck::testing::evaluateVcxprojCondition(" $(Configuration.Contains('Address'))", "Debug-AddressSanitizer", "Win32"));

0 commit comments

Comments
 (0)