Replace bare /dev/tty reads with prompt_confirm

Headless/unattended runs (cron, PHS_SILENT=1) have no /dev/tty, causing bare `read … </dev/tty` calls to fail with a device error or spin forever. Replace all such reads in network_check, pkg_update mirror fallback, check_container_resources, and check_container_storage with prompt_confirm (which respects is_unattended) and add clearer messages when a prompt is skipped automatically.

Author: MickLesk

lxc/alpine-install.func

@@ -129,8 +129,8 @@ network_check() {
   fi
 
   if [[ $ipv4_connected == false ]]; then
-    read -r -p "No Internet detected, would you like to continue anyway? <y/N> " prompt </dev/tty
-    if [[ "${prompt,,}" =~ ^(y|yes)$ ]]; then
+    # See lxc/install.func: a bare read from /dev/tty kills a headless install.
+    if prompt_confirm "No Internet detected, would you like to continue anyway?" "n"; then
       echo -e "${INFO}${RD}Expect Issues Without Internet${CL}"
     else
       echo -e "${NETWORK}Check Network Settings"

lxc/install.func

@@ -518,8 +518,12 @@ pkg_update() {
         else
           msg_warn "Find Debian mirrors at: https://www.debian.org/mirror/list"
         fi
-        while true; do
-          read -rp "  Enter a mirror hostname (or 'skip' to abort): " custom_mirror </dev/tty
+        # Only ask when there is someone to answer. Headless, /dev/tty does not
+        # exist, the read fails instantly, custom_mirror stays empty and the
+        # `continue` below spins the loop forever instead of prompting. Falling
+        # through leaves apt_ok=false, which the caller reports properly.
+        while ! is_unattended; do
+          read -rp "  Enter a mirror hostname (or 'skip' to abort): " custom_mirror </dev/tty || break
           [[ -z "$custom_mirror" ]] && continue
           [[ "$custom_mirror" == "skip" ]] && break
           [[ ! "$custom_mirror" =~ ^[a-zA-Z0-9._-]+$ ]] && {
@@ -1162,8 +1166,10 @@ network_check() {
 
   # If both IPv4 and IPv6 checks fail, prompt the user
   if [[ $ipv4_connected == false && $ipv6_connected == false ]]; then
-    read -r -p "No Internet detected, would you like to continue anyway? <y/N> " prompt </dev/tty
-    if [[ "${prompt,,}" =~ ^(y|yes)$ ]]; then
+    # prompt_confirm, not a bare read from /dev/tty: an install driven from cron
+    # or any other headless context has no /dev/tty, and reading from it there
+    # aborted with a device error instead of answering the question.
+    if prompt_confirm "No Internet detected, would you like to continue anyway?" "n"; then
       echo -e "${INFO}${RD}Expect Issues Without Internet${CL}"
     else
       echo -e "${NETWORK}Check Network Settings"

ui/menu.func

@@ -423,10 +423,17 @@ check_container_resources() {
   if [[ "$current_ram" -lt "$var_ram" ]] || [[ "$current_cpu" -lt "$var_cpu" ]]; then
     echo -e "\n${INFO}${HOLD} ${GN}Required: ${var_cpu} CPU, ${var_ram}MB RAM ${CL}| ${RD}Current: ${current_cpu} CPU, ${current_ram}MB RAM${CL}"
     echo -e "${YWB}Please ensure that the ${APP} LXC is configured with at least ${var_cpu} vCPU and ${var_ram} MB RAM for the build process.${CL}\n"
-    echo -ne "${INFO}${HOLD} May cause data loss! ${INFO} Continue update with under-provisioned LXC? <yes/No>  "
-    read -r prompt </dev/tty
-    if [[ ! ${prompt,,} =~ ^(yes)$ ]]; then
-      echo -e "${CROSS}${HOLD} ${YWB}Exiting based on user input.${CL}"
+    # prompt_confirm, not a bare read from /dev/tty. update-apps.sh exports
+    # PHS_SILENT=1 for unattended runs and cron has no /dev/tty at all, so the
+    # read failed the whole update with a device error instead of answering the
+    # question it was asked.
+    echo -e "${INFO}${HOLD} ${RD}May cause data loss!${CL}"
+    if ! prompt_confirm "Continue update with under-provisioned LXC?" "n"; then
+      if is_unattended; then
+        echo -e "${CROSS}${HOLD} ${YWB}Not continuing: LXC is under-provisioned and there is nobody to ask.${CL}"
+      else
+        echo -e "${CROSS}${HOLD} ${YWB}Exiting based on user input.${CL}"
+      fi
       exit 113 # user aborted an under-provisioned update
     fi
   else
@@ -450,16 +457,16 @@ check_container_storage() {
 
   if [ "$usage" -gt 80 ]; then
     echo -e "${INFO}${HOLD}${YWB}Warning: Storage is dangerously low (${usage}%).${CL}"
-    printf "Continue anyway? <y/N>  "
-    read -r prompt </dev/tty
-
-    case "$prompt" in
-    [yY][eE][sS] | [yY]) ;;
-    *)
-      echo -e "${CROSS}${HOLD}${YWB}Exiting based on user input.${CL}"
+    # See check_container_resources above for why this is not a bare read.
+    if ! prompt_confirm "Continue anyway?" "n"; then
+      if is_unattended; then
+        echo -e "${CROSS}${HOLD}${YWB}Not continuing: only $((100 - usage))% of / is free and there is nobody to ask.${CL}"
+        echo -e "${TAB}${YWB}An upgrade that runs out of disk mid-dpkg leaves the container broken.${CL}"
+      else
+        echo -e "${CROSS}${HOLD}${YWB}Exiting based on user input.${CL}"
+      fi
       exit 114 # user aborted with storage too low
-      ;;
-    esac
+    fi
   fi
 }