Merge branch 'master' into simd-revisite

Author: shai-almog

.github/scripts/update_material_icons.py

@@ -0,0 +1,134 @@
+#!/usr/bin/env python3
+"""Updates Codename One Material icon font and FontImage constants from upstream."""
+
+from __future__ import annotations
+
+import argparse
+import hashlib
+import pathlib
+import re
+import sys
+import urllib.request
+
+REPO_ROOT = pathlib.Path(__file__).resolve().parents[2]
+FONT_PATH = REPO_ROOT / "CodenameOne" / "src" / "material-design-font.ttf"
+FONT_IMAGE_PATH = REPO_ROOT / "CodenameOne" / "src" / "com" / "codename1" / "ui" / "FontImage.java"
+
+MATERIAL_FONT_URL = (
+    "https://raw.githubusercontent.com/google/material-design-icons/master/font/MaterialIcons-Regular.ttf"
+)
+MATERIAL_CODEPOINTS_URL = (
+    "https://raw.githubusercontent.com/google/material-design-icons/master/font/MaterialIcons-Regular.codepoints"
+)
+MATERIAL_CSS_URL = "https://fonts.googleapis.com/icon?family=Material+Icons"
+
+CONSTANT_DOC = "    /// Material design icon font character code see\\n    /// https://www.material.io/resources/icons/ for full list\\n"
+CONSTANT_RE = re.compile(r"^\s*public static final char MATERIAL_")
+SENTINEL = "    private static Font materialDesignFont;"
+
+
+def download_text(url: str) -> str:
+    with urllib.request.urlopen(url) as response:
+        return response.read().decode("utf-8")
+
+
+def download_bytes(url: str) -> bytes:
+    with urllib.request.urlopen(url) as response:
+        return response.read()
+
+
+def hash_bytes(data: bytes) -> str:
+    return hashlib.sha256(data).hexdigest()
+
+
+def material_constant_name(icon_name: str) -> str:
+    return "MATERIAL_" + re.sub(r"[^A-Z0-9_]", "_", icon_name.upper())
+
+
+def parse_codepoints(codepoints_text: str) -> list[tuple[str, str]]:
+    out: list[tuple[str, str]] = []
+    for line in codepoints_text.splitlines():
+        line = line.strip()
+        if not line:
+            continue
+        parts = line.split()
+        if len(parts) != 2:
+            raise ValueError(f"Unexpected codepoints line format: {line}")
+        out.append((parts[0], parts[1]))
+    return out
+
+
+def generate_constants_block(entries: list[tuple[str, str]]) -> str:
+    lines: list[str] = []
+    for icon_name, codepoint in entries:
+        const_name = material_constant_name(icon_name)
+        lines.append(CONSTANT_DOC.rstrip("\n"))
+        lines.append(f"    public static final char {const_name} = '\\u{codepoint.upper()}';")
+    return "\n".join(lines) + "\n"
+
+
+def update_fontimage(constants_block: str, check_only: bool) -> bool:
+    source = FONT_IMAGE_PATH.read_text(encoding="utf-8")
+    lines = source.splitlines(keepends=True)
+
+    start_idx = None
+    end_idx = None
+    for i, line in enumerate(lines):
+        if start_idx is None and CONSTANT_RE.match(line):
+            start_idx = i
+        if line.strip("\n") == SENTINEL:
+            end_idx = i
+            break
+
+    if start_idx is None or end_idx is None or start_idx >= end_idx:
+        raise RuntimeError("Couldn't locate material constants block in FontImage.java")
+
+    new_source = "".join(lines[:start_idx]) + constants_block + "".join(lines[end_idx:])
+    changed = new_source != source
+    if changed and not check_only:
+        FONT_IMAGE_PATH.write_text(new_source, encoding="utf-8")
+    return changed
+
+
+def update_font(remote_font_bytes: bytes, check_only: bool) -> bool:
+    local_font_bytes = FONT_PATH.read_bytes()
+    changed = hash_bytes(local_font_bytes) != hash_bytes(remote_font_bytes)
+    if changed and not check_only:
+        FONT_PATH.write_bytes(remote_font_bytes)
+    return changed
+
+
+def extract_css_font_version(css: str) -> str | None:
+    match = re.search(r"/materialicons/v(\d+)/", css)
+    return match.group(1) if match else None
+
+
+def main() -> int:
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument("--check", action="store_true", help="Only check if an update is needed")
+    args = parser.parse_args()
+
+    print("Fetching Material Icons metadata...")
+    css = download_text(MATERIAL_CSS_URL)
+    version = extract_css_font_version(css)
+    if version:
+        print(f"Detected Google Fonts Material Icons version: v{version}")
+
+    remote_font = download_bytes(MATERIAL_FONT_URL)
+    codepoints = download_text(MATERIAL_CODEPOINTS_URL)
+    entries = parse_codepoints(codepoints)
+    constants_block = generate_constants_block(entries)
+
+    font_changed = update_font(remote_font, check_only=args.check)
+    constants_changed = update_fontimage(constants_block, check_only=args.check)
+
+    if font_changed or constants_changed:
+        print("Material icons update detected.")
+        return 0
+
+    print("Material icons are already up to date.")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

.github/workflows/material-icons-update.yml

@@ -0,0 +1,71 @@
+name: Material Icons Update
+
+on:
+  schedule:
+    - cron: '0 6 * * 1'
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - '.github/workflows/material-icons-update.yml'
+      - '.github/scripts/update_material_icons.py'
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  update-material-icons:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
+
+      - name: Update Material Icons font and constants (scheduled/manual)
+        if: github.event_name != 'pull_request'
+        run: python .github/scripts/update_material_icons.py
+
+      - name: Create pull request
+        if: github.event_name != 'pull_request'
+        uses: peter-evans/create-pull-request@v7
+        with:
+          commit-message: "Update Material Icons font and FontImage constants"
+          title: "Update Material Icons font and FontImage constants"
+          body: |
+            ## Summary
+            - Updates `CodenameOne/src/material-design-font.ttf` from upstream Material Icons.
+            - Regenerates `FontImage.MATERIAL_*` constants from upstream codepoints.
+
+            This PR was created automatically by the weekly Material Icons update workflow.
+          base: master
+          branch: automation/material-icons-update
+          delete-branch: true
+          labels: |
+            dependencies
+            automation
+
+      - name: Build update preview for PR validation
+        if: github.event_name == 'pull_request'
+        run: |
+          python .github/scripts/update_material_icons.py
+          if git diff --quiet; then
+            echo "Material icons are already up to date." > material-icons-update-summary.txt
+          else
+            echo "Material icons update detected; see attached patch artifact." > material-icons-update-summary.txt
+            git diff --binary > material-icons-update.patch
+          fi
+
+      - name: Upload PR validation artifacts
+        if: github.event_name == 'pull_request'
+        uses: actions/upload-artifact@v4
+        with:
+          name: material-icons-update-preview
+          path: |
+            material-icons-update-summary.txt
+            material-icons-update.patch
+          if-no-files-found: error

CodenameOne/src/com/codename1/annotations/Concrete.java

@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2012, Codename One and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.  Codename One designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Codename One through http://www.codenameone.com/ if you
+ * need additional information or have any questions.
+ */
+package com.codename1.annotations;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/// Indicates that a class has a known concrete implementation that ParparVM can
+/// target directly in native (C/Objective-C) pipelines.
+///
+/// When present, the translator may bypass virtual lookup when invoking methods
+/// on this type by preferring the concrete class provided in {@link #name()},
+/// and falling back to the annotated type implementation if the concrete class
+/// doesn't implement the method.
+@Retention(RetentionPolicy.CLASS)
+@Target(ElementType.TYPE)
+public @interface Concrete {
+    /// The fully-qualified class name of the concrete implementation to prefer
+    /// during ParparVM native translation.
+    String name();
+}

CodenameOne/src/com/codename1/components/InteractionDialog.java

@@ -637,8 +637,11 @@ public void showPopupDialog(Component c) {
     ///
     /// - `c`: the context component which is used to position the dialog and can also be pointed at
     ///
-    /// - `bias`: @param bias biases the dialog to appear above/below or to the sides.
-    /// This is ignored if there isn't enough space
+    /// - `bias`: directional bias value. This parameter is not supported.
+    ///
+    /// #### Deprecated
+    ///
+    /// @deprecated The `bias` parameter is not supported for `InteractionDialog` popups. Use `#showPopupDialog(Component)` instead.
     public void showPopupDialog(Component c, boolean bias) {
         if (c == null) {
             throw new IllegalArgumentException("Component cannot be null");
@@ -653,7 +656,7 @@ public void showPopupDialog(Component c, boolean bias) {
         componentPos.setX(componentPos.getX() - c.getScrollX());
         componentPos.setY(componentPos.getY() - c.getScrollY());
         setOwner(c);
-        showPopupDialog(componentPos, bias);
+        showPopupDialog(componentPos);
     }
 
     /// A popup dialog is shown with the context of a component and  its selection. You should use `#setDisposeWhenPointerOutOfBounds(boolean)` to make it dispose
@@ -664,7 +667,7 @@ public void showPopupDialog(Component c, boolean bias) {
     ///
     /// - `rect`: the screen rectangle to which the popup should point
     public void showPopupDialog(Rectangle rect) {
-        showPopupDialog(rect, Display.getInstance().isPortrait());
+        showPopupDialogImpl(rect, Display.getInstance().isPortrait());
     }
 
     /// A popup dialog is shown with the context of a component and  its selection. You should use `#setDisposeWhenPointerOutOfBounds(boolean)` to make it dispose
@@ -675,9 +678,16 @@ public void showPopupDialog(Rectangle rect) {
     ///
     /// - `rect`: the screen rectangle to which the popup should point
     ///
-    /// - `bias`: @param bias biases the dialog to appear above/below or to the sides.
-    /// This is ignored if there isn't enough space
+    /// - `bias`: directional bias value. This parameter is not supported.
+    ///
+    /// #### Deprecated
+    ///
+    /// @deprecated The `bias` parameter is not supported for `InteractionDialog` popups. Use `#showPopupDialog(Rectangle)` instead.
     public void showPopupDialog(Rectangle rect, boolean bias) {
+        showPopupDialog(rect);
+    }
+
+    private void showPopupDialogImpl(Rectangle rect, boolean bias) {
         if (rect == null) {
             throw new IllegalArgumentException("rect cannot be null");
         }

CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java

@@ -23,6 +23,7 @@
  */
 package com.codename1.impl;
 
+import com.codename1.annotations.Concrete;
 import com.codename1.capture.VideoCaptureConstraints;
 import com.codename1.codescan.CodeScanner;
 import com.codename1.components.AudioRecorderComponent;
@@ -110,6 +111,7 @@
 /// Display specifically for key, pointer events and screen resolution.
 ///
 /// @author Shai Almog
+@Concrete(name = "com.codename1.impl.ios.IOSImplementation")
 public abstract class CodenameOneImplementation {
     /// Indicates the range of "hard" RTL bidi characters in unicode
     private static final int RTL_RANGE_BEGIN = 0x590;

CodenameOne/src/com/codename1/ui/TextArea.java

@@ -597,6 +597,13 @@ public void setText(String t) {
             //zero the ArrayList in order to initialize it on the next paint
             rowStrings = null;
         }
+        if (growByContent
+                && !Objects.equals(text, old)
+                && getParent() != null
+                && Display.getInstance().isTextEditing(this)
+                && textMightGrowByContent(old, text)) {
+            getParent().revalidateLater();
+        }
         if (!Objects.equals(text, old)) {
             fireDataChanged(DataChangedListener.CHANGED, -1);
         }
@@ -610,6 +617,53 @@ public void setText(String t) {
         repaint();
     }
 
+    private boolean textMightGrowByContent(String oldText, String newText) {
+        int oldNewLines = countNewLines(oldText);
+        int newNewLines = countNewLines(newText);
+        if (newNewLines > oldNewLines) {
+            return true;
+        }
+        if (newText == null || oldText == null || newText.length() <= oldText.length()) {
+            return false;
+        }
+        int cols = getColumns();
+        if (cols > 1) {
+            return estimateLineCount(newText, cols) > estimateLineCount(oldText, cols);
+        }
+        return false;
+    }
+
+    private int countNewLines(String value) {
+        if (value == null || value.length() == 0) {
+            return 0;
+        }
+        int count = 0;
+        for (int i = 0; i < value.length(); i++) {
+            if (value.charAt(i) == '\n') {
+                count++;
+            }
+        }
+        return count;
+    }
+
+    private int estimateLineCount(String value, int cols) {
+        if (value == null || value.length() == 0) {
+            return 1;
+        }
+        int lines = 0;
+        int segmentLength = 0;
+        for (int i = 0; i < value.length(); i++) {
+            if (value.charAt(i) == '\n') {
+                lines += Math.max(1, (segmentLength + cols - 1) / cols);
+                segmentLength = 0;
+            } else {
+                segmentLength++;
+            }
+        }
+        lines += Math.max(1, (segmentLength + cols - 1) / cols);
+        return lines;
+    }
+
     /// Convenience method for numeric text fields, returns the value as a number or invalid if the value in the
     /// text field isn't a number
     ///