Merge pull request #8864 from paulbalandan/ordered-attributes

style: enable `ordered_attributes`

Author: kenjis

.php-cs-fixer.dist.php

@@ -44,6 +44,7 @@
 $overrides = [
     // for updating to coding-standard
     'modernize_strpos'    => true,
+    'ordered_attributes'  => ['order' => [], 'sort_algorithm' => 'alpha'],
     'php_unit_attributes' => true,
 ];
 

.php-cs-fixer.no-header.php

@@ -32,6 +32,7 @@
 $overrides = [
     // for updating to coding-standard
     'modernize_strpos'    => true,
+    'ordered_attributes'  => ['order' => [], 'sort_algorithm' => 'alpha'],
     'php_unit_attributes' => true,
 ];
 

.php-cs-fixer.tests.php

@@ -37,6 +37,7 @@
     'void_return' => true,
     // for updating to coding-standard
     'modernize_strpos'    => true,
+    'ordered_attributes'  => ['order' => [], 'sort_algorithm' => 'alpha'],
     'php_unit_attributes' => true,
 ];
 

.php-cs-fixer.user-guide.php

@@ -41,6 +41,7 @@
     ],
     // for updating to coding-standard
     'modernize_strpos'    => true,
+    'ordered_attributes'  => ['order' => [], 'sort_algorithm' => 'alpha'],
     'php_unit_attributes' => true,
 ];
 

tests/system/Autoloader/AutoloaderTest.php

@@ -392,8 +392,8 @@ public function testAutoloaderLoadsNonClassFiles(): void
         $loader->unregister();
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testLoadHelpers(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.

tests/system/CodeIgniterTest.php

@@ -40,9 +40,9 @@
 /**
  * @internal
  */
-#[RunTestsInSeparateProcesses]
 #[BackupGlobals(true)]
 #[Group('Others')]
+#[RunTestsInSeparateProcesses]
 final class CodeIgniterTest extends CIUnitTestCase
 {
     private CodeIgniter $codeigniter;

tests/system/Commands/GenerateKeyTest.php

@@ -88,8 +88,8 @@ public function testGenerateKeyShowsEncodedKey(): void
         $this->assertStringContainsString('hex2bin:', $this->getBuffer());
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testGenerateKeyCreatesNewKey(): void
     {
         command('key:generate');

tests/system/CommonFunctionsSendTest.php

@@ -39,8 +39,8 @@ protected function setUp(): void
      * Make sure cookies are set by RedirectResponse this way
      * See https://github.com/codeigniter4/CodeIgniter4/issues/1393
      */
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testRedirectResponseCookiesSent(): void
     {
         $loginTime = time();

tests/system/CommonFunctionsTest.php

@@ -272,8 +272,8 @@ public function testEscapeRecursiveArrayRaw(): void
         $this->assertSame($data, esc($data, 'raw'));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testSessionInstance(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -285,8 +285,8 @@ public function testSessionInstance(): void
         $this->assertInstanceOf(Session::class, session());
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testSessionVariable(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -300,8 +300,8 @@ public function testSessionVariable(): void
         $this->assertSame('Hi there', session('notbogus'));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testSessionVariableNotThere(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -426,8 +426,8 @@ public function testModelExistsAbsoluteClassname(): void
         $this->assertInstanceOf(JobModel::class, model(JobModel::class));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testOldInput(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -463,8 +463,8 @@ public function testOldInput(): void
         $this->assertSame('fritz', old('zibble'));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testOldInputSerializeData(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -501,8 +501,8 @@ public function testOldInputSerializeData(): void
     /**
      * @see https://github.com/codeigniter4/CodeIgniter4/issues/1492
      */
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testOldInputArray(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -620,8 +620,8 @@ public function testRedirectResponseCookies1(): void
         $this->assertTrue($answer1->hasCookie('login_time'));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testTrace(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -645,8 +645,8 @@ public function testViewNotSaveData(): void
         $this->assertStringContainsString('<h1>is_not</h1>', view('\Tests\Support\View\Views\simples'));
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testForceHttpsNullRequestAndResponse(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.
@@ -761,8 +761,8 @@ public function testDWithCSP(): void
         Kint::$cli_detection = $cliDetection;
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
+    #[RunInSeparateProcess]
     public function testTraceWithCSP(): void
     {
         // Workaround for errors on PHPUnit 10 and PHP 8.3.

tests/system/CommonHelperTest.php

@@ -25,8 +25,8 @@
 /**
  * @internal
  */
-#[Group('Others')]
 #[CoversFunction('helper')]
+#[Group('Others')]
 final class CommonHelperTest extends CIUnitTestCase
 {
     private array $dummyHelpers = [