apply code suggestions

Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>

Author: michalsn

system/I18n/TimeTrait.php

@@ -1021,13 +1021,11 @@ public function isAfter($testTime, ?string $timezone = null): bool
      *
      * If $start is after $end, the arguments are swapped.
      *
-     * @param DateTimeInterface|self|string $start
-     * @param DateTimeInterface|self|string $end
-     * @param string|null                   $timezone Used only when $start or $end is a string.
+     * @param string|null $timezone Used only when $start or $end is a string.
      *
      * @throws Exception
      */
-    public function between($start, $end, bool $equals = true, ?string $timezone = null): bool
+    public function between(DateTimeInterface|string $start, DateTimeInterface|string $end, bool $inclusive = true, ?string $timezone = null): bool
     {
         $start = $this->normalizeTime($start, $timezone);
         $end   = $this->normalizeTime($end, $timezone);
@@ -1036,7 +1034,7 @@ public function between($start, $end, bool $equals = true, ?string $timezone = n
             [$start, $end] = [$end, $start];
         }
 
-        if ($equals) {
+        if ($inclusive) {
             return ! $this->isBefore($start) && ! $this->isAfter($end);
         }
 
@@ -1048,12 +1046,11 @@ public function between($start, $end, bool $equals = true, ?string $timezone = n
      *
      * If null is provided, compares against now in the current timezone.
      *
-     * @param DateTimeInterface|self|string|null $time
-     * @param string|null                        $timezone Used only when $time is a string or null.
+     * @param string|null $timezone Used only when $time is a string or null.
      *
      * @throws Exception
      */
-    public function min($time = null, ?string $timezone = null): static
+    public function min(DateTimeInterface|string|null $time = null, ?string $timezone = null): static
     {
         $time = $this->normalizeTime($time, $timezone);
 
@@ -1065,12 +1062,11 @@ public function min($time = null, ?string $timezone = null): static
      *
      * If null is provided, compares against now in the current timezone.
      *
-     * @param DateTimeInterface|self|string|null $time
-     * @param string|null                        $timezone Used only when $time is a string or null.
+     * @param string|null $timezone Used only when $time is a string or null.
      *
      * @throws Exception
      */
-    public function max($time = null, ?string $timezone = null): static
+    public function max(DateTimeInterface|string|null $time = null, ?string $timezone = null): static
     {
         $time = $this->normalizeTime($time, $timezone);
 
@@ -1206,11 +1202,9 @@ public function getUTCObject($time, ?string $timezone = null)
      * or the current instance's timezone when omitted. If null is provided,
      * the current time is used in the same timezone.
      *
-     * @param DateTimeInterface|self|string|null $time
-     *
      * @throws Exception
      */
-    private function normalizeTime($time, ?string $timezone = null): static
+    private function normalizeTime(DateTimeInterface|string|null $time, ?string $timezone = null): static
     {
         if ($time instanceof DateTimeInterface) {
             return static::createFromInstance($time, $this->locale);

user_guide_src/source/libraries/time.rst

@@ -401,7 +401,7 @@ between()
 .. versionadded:: 4.8.0
 
 Determines if the current instance is between two other times. By default, the start and end bounds are included.
-Pass ``false`` as the third argument to exclude both bounds:
+Pass ``false`` as the third ``$inclusive`` argument to exclude both bounds:
 
 .. literalinclude:: time/045.php