Skip to content

Commit 9fe8129

Browse files
DavertMikclaude
andcommitted
fix: remove -p all special case from dry-run command
The 'all' magic keyword conflicted with the new colon-separated plugin arguments syntax. Users can still enable specific plugins in dry-run via -p pluginName1,pluginName2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent fe748ee commit 9fe8129

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

lib/command/dryRun.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ export default async function (test, options) {
2020
if (config.plugins) {
2121
// disable all plugins by default, they can be enabled with -p option
2222
for (const plugin in config.plugins) {
23-
// if `-p all` is passed, then enabling all plugins, otherwise plugins could be enabled by `-p customLocator,commentStep,tryTo`
24-
config.plugins[plugin].enabled = options.plugins === 'all'
23+
config.plugins[plugin].enabled = false
2524
}
2625
}
2726

test/runner/dry_run_test.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -186,17 +186,6 @@ describe('dry-run command', () => {
186186
})
187187
})
188188

189-
it('should enable all plugins in dry-mode when passing -p all', done => {
190-
exec(`${codecept_run_config('codecept.customLocator.js')} --verbose -p all`, (err, stdout) => {
191-
expect(stdout).toContain('Plugins: screenshotOnFail, customLocator')
192-
expect(stdout).toContain("I see element {xpath: .//*[@data-testid='COURSE']//a}")
193-
expect(stdout).toContain('OK | 1 passed')
194-
expect(stdout).toContain('--- DRY MODE: No tests were executed ---')
195-
expect(err).toBeFalsy()
196-
done()
197-
})
198-
})
199-
200189
it('should enable a particular plugin in dry-mode when passing it to -p', done => {
201190
exec(`${codecept_run_config('codecept.customLocator.js')} --verbose -p customLocator`, (err, stdout) => {
202191
expect(stdout).toContain('Plugins: customLocator')

0 commit comments

Comments
 (0)