Convert test assertions from .should to expect() syntax

Converted all .should chain assertions to expect() syntax across unit tests to fix ESM migration issues where error objects may lack proper message property causing test framework failures.

- test/unit/bdd_test.js: listeners.should.eql, printed/lines.should.include.members
- test/unit/html_test.js: result.should.include
- test/unit/mocha/ui_test.js: suite/test.tags.should.include/not.include
- test/unit/plugin/retryFailedStep_test.js: counter/initalIndex.should.equal
- test/unit/utils_test.js: getNormalizedKeyAttributeValue().should.equal

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: 2 people

test/unit/bdd_test.js

@@ -224,9 +224,9 @@ describe('BDD', () => {
     return new Promise(resolve => {
       suite.tests[0].fn(() => {
         recorder.promise().then(() => {
-          printed.should.include.members(['add 600', 'add 1600', 'add finish checkout'])
+          expect(printed).to.include.members(['add 600', 'add 1600', 'add finish checkout'])
           const lines = recorder.scheduled().split('\n')
-          lines.should.include.members([
+          expect(lines).to.include.members([
             'do: "add", 600',
             'step passed',
             'return result',
@@ -266,7 +266,7 @@ describe('BDD', () => {
     const suite = await run(text)
     return new Promise(resolve => {
       suite.tests[0].fn(() => {
-        listeners.should.eql(2)
+        expect(listeners).to.eql(2)
         resolve()
       })
     })

test/unit/html_test.js

@@ -113,9 +113,9 @@ describe('HTML module', () => {
     it('should cut out all non-interactive elements from GitLab HTML', () => {
       html = fs.readFileSync(path.join(__dirname, '../data/gitlab.html'), 'utf8')
       const result = removeNonInteractiveElements(html, opts)
-      result.should.include('Get free trial')
-      result.should.include('Sign in')
-      result.should.include('<button')
+      expect(result).to.include('Get free trial')
+      expect(result).to.include('Sign in')
+      expect(result).to.include('<button')
 
       const $ = cheerio.load(result)
       const nodes = $('input[placeholder="Search"]')
@@ -125,7 +125,7 @@ describe('HTML module', () => {
     it('should cut out and minify Testomatio HTML', () => {
       html = fs.readFileSync(path.join(__dirname, '../data/testomat.html'), 'utf8')
       const result = removeNonInteractiveElements(html, opts)
-      result.should.include('<svg class="md-icon md-icon-check-bold')
+      expect(result).to.include('<svg class="md-icon md-icon-check-bold')
     })
   })
 

test/unit/mocha/ui_test.js

@@ -55,15 +55,15 @@ describe('ui', () => {
       suiteConfig = context.Feature('basic suite @very @important')
       expect(suiteConfig.suite).is.ok
 
-      suiteConfig.suite.tags.should.include('@very')
-      suiteConfig.suite.tags.should.include('@important')
+      expect(suiteConfig.suite.tags).to.include('@very')
+      expect(suiteConfig.suite.tags).to.include('@important')
 
       suiteConfig.tag('@user')
-      suiteConfig.suite.tags.should.include('@user')
+      expect(suiteConfig.suite.tags).to.include('@user')
 
-      suiteConfig.suite.tags.should.not.include('@slow')
+      expect(suiteConfig.suite.tags).to.not.include('@slow')
       suiteConfig.tag('slow')
-      suiteConfig.suite.tags.should.include('@slow')
+      expect(suiteConfig.suite.tags).to.include('@slow')
     })
 
     it('retries can be set', () => {
@@ -234,12 +234,12 @@ describe('ui', () => {
 
       scenarioConfig = context.Scenario('scenario @very @important')
 
-      scenarioConfig.test.tags.should.include('@cool')
-      scenarioConfig.test.tags.should.include('@very')
-      scenarioConfig.test.tags.should.include('@important')
+      expect(scenarioConfig.test.tags).to.include('@cool')
+      expect(scenarioConfig.test.tags).to.include('@very')
+      expect(scenarioConfig.test.tags).to.include('@important')
 
       scenarioConfig.tag('@user')
-      scenarioConfig.test.tags.should.include('@user')
+      expect(scenarioConfig.test.tags).to.include('@user')
     })
 
     it('should dynamically inject dependencies', () => {

test/unit/plugin/retryFailedStep_test.js

@@ -71,7 +71,7 @@ describe('retryFailedStep', () => {
 
     expect(test.opts.conditionalRetries).to.equal(1)
     // expects to retry only once
-    counter.should.equal(2)
+    expect(counter).to.equal(2)
   })
 
   it('should not retry steps with wait*', async () => {
@@ -238,7 +238,7 @@ describe('retryFailedStep', () => {
 
     recorder.add(
       () => {
-        initalIndex.should.equal(getRetryIndex())
+        expect(initalIndex).to.equal(getRetryIndex())
       },
       undefined,
       undefined,

test/unit/utils_test.js

@@ -284,19 +284,19 @@ describe('utils', () => {
       sinon.stub(os, 'platform').callsFake(() => {
         return 'notdarwin'
       })
-      utils.getNormalizedKeyAttributeValue('CmdOrCtrl').should.equal('Control')
-      utils.getNormalizedKeyAttributeValue('COMMANDORCONTROL').should.equal('Control')
-      utils.getNormalizedKeyAttributeValue('ControlOrCommand').should.equal('Control')
-      utils.getNormalizedKeyAttributeValue('left ctrl or command').should.equal('ControlLeft')
+      expect(utils.getNormalizedKeyAttributeValue('CmdOrCtrl')).to.equal('Control')
+      expect(utils.getNormalizedKeyAttributeValue('COMMANDORCONTROL')).to.equal('Control')
+      expect(utils.getNormalizedKeyAttributeValue('ControlOrCommand')).to.equal('Control')
+      expect(utils.getNormalizedKeyAttributeValue('left ctrl or command')).to.equal('ControlLeft')
       os.platform.restore()
 
       sinon.stub(os, 'platform').callsFake(() => {
         return 'darwin'
       })
-      utils.getNormalizedKeyAttributeValue('CtrlOrCmd').should.equal('Meta')
-      utils.getNormalizedKeyAttributeValue('CONTROLORCOMMAND').should.equal('Meta')
-      utils.getNormalizedKeyAttributeValue('CommandOrControl').should.equal('Meta')
-      utils.getNormalizedKeyAttributeValue('right command or ctrl').should.equal('MetaRight')
+      expect(utils.getNormalizedKeyAttributeValue('CtrlOrCmd')).to.equal('Meta')
+      expect(utils.getNormalizedKeyAttributeValue('CONTROLORCOMMAND')).to.equal('Meta')
+      expect(utils.getNormalizedKeyAttributeValue('CommandOrControl')).to.equal('Meta')
+      expect(utils.getNormalizedKeyAttributeValue('right command or ctrl')).to.equal('MetaRight')
       os.platform.restore()
     })
   })