Skip to content

Commit c0c01e3

Browse files
committed
ci: build packages via their own build scripts
The CI workflow and Makefile hand-rolled the package build (tsc + tailwind only), silently skipping the 0.2.0 build steps that generate compat.css / shadcn.css and copy the voice/canvas subentry styles into dist — so web's 'jcode-ui/compat.css' import failed to resolve. Delegate to 'pnpm build' in each package so there is a single source of truth for build steps. Generated with Jack AI bot
1 parent f24f365 commit c0c01e3

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,14 @@ jobs:
9595
- name: Install monorepo deps
9696
run: pnpm install --frozen-lockfile || pnpm install
9797

98+
# Use the packages' own build scripts — they also generate compat.css,
99+
# shadcn.css and copy the voice/canvas subentry styles into dist/.
100+
# Hand-rolling tsc+tailwind here drifts the moment a package adds a
101+
# build step (exactly what broke ./compat.css resolution in 0.2.0).
98102
- name: Build packages
99103
run: |
100-
cd packages/jcode-ui-core && npx tsc -p tsconfig.build.json
101-
cd ../jcode-ui && npx tsc -p tsconfig.build.json
102-
npx tailwindcss -i src/styles/entry.css -o dist/styles.css --minify
104+
pnpm -C packages/jcode-ui-core build
105+
pnpm -C packages/jcode-ui build
103106
104107
- name: Type-check web app
105108
working-directory: web

Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,8 @@ generate:
4545
build-web: generate
4646
@echo "Building React frontend + packages..."
4747
-pnpm install --frozen-lockfile 2>/dev/null || true
48-
cd packages/jcode-ui-core && npx tsc -p tsconfig.build.json
49-
cd packages/jcode-ui && npx tsc -p tsconfig.build.json
50-
cd packages/jcode-ui && npx tailwindcss -i src/styles/entry.css -o dist/styles.css --minify
48+
cd packages/jcode-ui-core && pnpm build
49+
cd packages/jcode-ui && pnpm build
5150
cd web && npx vite build
5251

5352
# The main binary never links CoreBluetooth (whose eager init triggers the macOS

0 commit comments

Comments
 (0)