Skip to content

Commit 8461717

Browse files
james-zhou-inspire11tyler-dunkel
authored andcommitted
feat(dataproc): couple updates/fixes to the cluster
1 parent 81a56c9 commit 8461717

6 files changed

Lines changed: 21 additions & 16 deletions

File tree

src/enums/services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default {
2828
// composer: 'composer',
2929
// dataCatalog: 'data-catalog',
3030
// dataflow: 'dataflow',
31-
dataprocCluster: 'dataprocCluster',
31+
dataprocCluster: 'dataprocClusters',
3232
// metastore: 'metastore',
3333
// pubsub: 'pubsub',
3434
// bigtable: 'bigtable',

src/services/dataprocCluster/data.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,11 @@ import groupBy from 'lodash/groupBy'
55
import { google } from '@google-cloud/dataproc/build/protos/protos'
66
import gcpLoggerText from '../../properties/logger'
77
import { GcpServiceInput } from '../../types'
8-
import { initTestEndpoint, generateGcpErrorLog } from '../../utils'
8+
import { generateGcpErrorLog } from '../../utils'
99

1010
const lt = { ...gcpLoggerText }
1111
const { logger } = CloudGraph
1212
const serviceName = 'Dataproc Cluster'
13-
const apiEndpoint = initTestEndpoint(serviceName)
1413

1514
export interface RawGcpDataprocCluster extends Omit<google.cloud.dataproc.v1.ICluster, 'projectId' | 'labels'> {
1615
id: string
@@ -34,7 +33,11 @@ export default async ({
3433
*/
3534

3635
try {
37-
const dataprocClient = new ClusterControllerClient({ ...config, apiEndpoint })
36+
const dataprocClient = new ClusterControllerClient({
37+
...config,
38+
apiEndpoint: `${region}-dataproc.googleapis.com`,
39+
projectId,
40+
})
3841

3942
const iterable = dataprocClient.listClustersAsync({ projectId, region })
4043
for await (const { labels, ...response } of iterable) {

src/services/dataprocCluster/format.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ const formatClusterConfigLifecycle = ({
146146
idleStartTime,
147147
}: google.cloud.dataproc.v1.ILifecycleConfig): GcpDataprocClusterConfigLifecycleConfig => {
148148
return {
149-
idleDeleteTtl: idleDeleteTtl.seconds?.toString() || '',
149+
idleDeleteTtl: idleDeleteTtl?.seconds?.toString() || '',
150150
autoDeleteTime: toISOString(autoDeleteTime?.seconds?.toString()),
151-
autoDeleteTtl: autoDeleteTtl.seconds?.toString() || '',
151+
autoDeleteTtl: autoDeleteTtl?.seconds?.toString() || '',
152152
idleStartTime: toISOString(idleStartTime?.seconds?.toString()),
153153
}
154154
}
@@ -192,19 +192,19 @@ const formatClusterConfig = ({
192192
return {
193193
configBucket,
194194
tempBucket,
195-
gceClusterConfig: formatClusterConfigGceCluster(gceClusterConfig),
196-
masterConfig: formatClusterConfigInstanceGroup(masterConfig),
197-
workerConfig: formatClusterConfigInstanceGroup(workerConfig),
198-
secondaryWorkerConfig: formatClusterConfigInstanceGroup(secondaryWorkerConfig),
199-
softwareConfig: formatClusterConfigSoftware(softwareConfig),
195+
gceClusterConfig: formatClusterConfigGceCluster(gceClusterConfig || {}),
196+
masterConfig: formatClusterConfigInstanceGroup(masterConfig || {}),
197+
workerConfig: formatClusterConfigInstanceGroup(workerConfig || {}),
198+
secondaryWorkerConfig: formatClusterConfigInstanceGroup(secondaryWorkerConfig || {}),
199+
softwareConfig: formatClusterConfigSoftware(softwareConfig || {}),
200200
initializationActions: initializationActions?.map(formatClusterConfigNodeInitializationAction),
201201
encryptionConfigGcePdKmsKeyName: encryptionConfig?.gcePdKmsKeyName || '',
202202
autoscalingConfigPolicyUri: autoscalingConfig?.policyUri || '',
203-
securityConfig: formatClusterConfigSecurity(securityConfig),
204-
lifecycleConfig: formatClusterConfigLifecycle(lifecycleConfig),
205-
endpointConfig: formatClusterConfigEndpoint(endpointConfig),
203+
securityConfig: formatClusterConfigSecurity(securityConfig || {}),
204+
lifecycleConfig: formatClusterConfigLifecycle(lifecycleConfig || {}),
205+
endpointConfig: formatClusterConfigEndpoint(endpointConfig || {}),
206206
metastoreMetastoreServiceConfig: metastoreConfig?.dataprocMetastoreService || '',
207-
gkeClusterConfig: formatClusterConfigGke(gkeClusterConfig),
207+
gkeClusterConfig: formatClusterConfigGke(gkeClusterConfig || {}),
208208
}
209209
}
210210

src/services/dataprocCluster/schema.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,5 +197,5 @@ type gcpDataprocCluster implements gcpBaseResource
197197
clusterUuid: String @search(by: [hash, regexp])
198198
hdfsMetrics: [gcpDataprocClusterMetric]
199199
yarnMetrics: [gcpDataprocClusterMetric]
200-
project: [gcpProject] @hasInverse(field: dataprocCluster)
200+
project: [gcpProject] @hasInverse(field: dataprocClusters)
201201
}

src/services/project/schema.graphql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,5 @@ type gcpProject @key(fields: "id") {
4646
serviceAccounts: [gcpServiceAccount] @hasInverse(field: project)
4747
kmsCryptoKeys: [gcpKmsCryptoKey] @hasInverse(field: project)
4848
dataprocCluster: [gcpDataprocCluster] @hasInverse(field: project)
49+
dataprocClusters: [gcpDataprocCluster] @hasInverse(field: project)
4950
}

src/types/generated.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1446,6 +1446,7 @@ export type GcpProject = {
14461446
computeProject?: Maybe<Array<Maybe<GcpComputeProject>>>;
14471447
createTime?: Maybe<Scalars['String']>;
14481448
dataprocCluster?: Maybe<Array<Maybe<GcpDataprocCluster>>>;
1449+
dataprocClusters?: Maybe<Array<Maybe<GcpDataprocCluster>>>;
14491450
deleteTime?: Maybe<Scalars['String']>;
14501451
displayName?: Maybe<Scalars['String']>;
14511452
dnsManagedZone?: Maybe<Array<Maybe<GcpDnsManagedZone>>>;

0 commit comments

Comments
 (0)